Merged
Conversation
43 tasks
b0d88c2 to
2d6b3d5
Compare
Member
There was a problem hiding this comment.
maybe move all these if checks to execute method? (I personally find that easier to read, when we get in do* method we know we're good to go) Like this:
if (update != null) {
doUpdate(data);
}
// next if
Member
There was a problem hiding this comment.
I think for consistency with the rest of the code base we should use three lines for these if statements?
b60b012 to
14f9fbc
Compare
Member
|
LGTM |
fix forbiddenapis update clean up and add rest test update mutate factory to use configuration utilities compile gsub pattern cleanup, update parseBooleans, null tests
14f9fbc to
8fc5a3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meant to have feature parity with logstash-filter-mutate