add ability to add nested field values to Data document#14250
Merged
talevy merged 2 commits intoelastic:feature/ingestfrom Oct 28, 2015
Merged
add ability to add nested field values to Data document#14250talevy merged 2 commits intoelastic:feature/ingestfrom
talevy merged 2 commits intoelastic:feature/ingestfrom
Conversation
43 tasks
Member
There was a problem hiding this comment.
When we back port this to the 2.x branch then this will fail because putIfAbsent is java8 only... Fixing this would be easy and I think in master we should keep this. Maybe just add a comment saying that when we back port we need to add a helper method or something like that.
Contributor
Author
There was a problem hiding this comment.
oh, no its fine. I was just in search of ways to reduce conditional branches to make things more readable. I will just go ahead and add an if to remove this java8 dep
Member
|
Left some minor comments OTT LGTM. |
2add01f to
cf52ab5
Compare
Contributor
Author
|
tests added. @martijnvg, mind taking another look at this? I will add more functionality in another PR to respond to this: #14324. |
Member
|
LGTM |
talevy
added a commit
that referenced
this pull request
Oct 28, 2015
add ability to add nested field values to Data document
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small commit to add ability to add nested paths.
This will be used by processors such as
mutatefor building custom document structure.