[ES|QL] Channels issue when an agg is called with the same field (#142180)#142269
Merged
mouhc1ne merged 10 commits intoelastic:mainfrom Feb 27, 2026
Merged
[ES|QL] Channels issue when an agg is called with the same field (#142180)#142269mouhc1ne merged 10 commits intoelastic:mainfrom
mouhc1ne merged 10 commits intoelastic:mainfrom
Conversation
…stic#142180) - Preserve duplicate attributes when the same field is passed twice in an agg function.
alex-spies
reviewed
Feb 11, 2026
Contributor
alex-spies
left a comment
There was a problem hiding this comment.
Thanks @mouhc1ne , fix looks correct to me!
If CI doesn't complain, let's add some tests (esp. a reproducer for the FIRST/LAST bug this fixes) and reach out to Nhat for additional review :)
- Add csv-test - Explicitly reject null type from the second parameter of FIRST/LAST
dnhatn
reviewed
Feb 26, 2026
.../main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/AggregateFunction.java
Outdated
Show resolved
Hide resolved
.../org/elasticsearch/xpack/esql/expression/function/aggregate/TimeSeriesAggregateFunction.java
Outdated
Show resolved
Hide resolved
alex-spies
reviewed
Feb 26, 2026
Contributor
alex-spies
left a comment
There was a problem hiding this comment.
Re-reviewed. The null-type fix looks separate and should maybe be a separate PR. Otherwise LGTM.
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/First.java
Outdated
Show resolved
Hide resolved
dnhatn
approved these changes
Feb 26, 2026
…ibutes-and-channels # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Feb 27, 2026
…cations * upstream/main: Warn on API key version mismatch (elastic#143127) Fixed wrong malformed value ordering in synthetic source tests (elastic#143187) [ML] Fix: required_native_memory_bytes Calculated with Wrong Allocation Count (elastic#143077) Add configureBenchmarkLogging calls across the various benchmarks (elastic#143185) Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:k8s-timeseries-avg-over-time.Avg_over_time_aggregate_metric_double_implicit_casting} elastic#143292 Give system role permission to invoke shard refresh (elastic#143190) Mute testSyntheticSourceWithTranslogSnapshot (elastic#143260) Adds ResumeInfo Tests (elastic#142769) Use a static method to configure benchmark logging (elastic#143056) add connectors release notes (elastic#142884) Add CI triage guidance for AI agents (elastic#142994) ESQL: Data sources: ZSTD, BZIP2 (elastic#143228) [ES|QL] Channels issue when an agg is called with the same field (elastic#142180) (elastic#142269) Add support for project routing in reindex requests (elastic#142240)
tballison
pushed a commit
to tballison/elasticsearch
that referenced
this pull request
Mar 3, 2026
…stic#142180) (elastic#142269) - Preserve duplicate attributes when the same field is passed twice in an agg function. - Add csv-test and capability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.