Cleanup IndexMetaData#14119
Merged
jasontedor merged 1 commit intoelastic:masterfrom Oct 14, 2015
jasontedor:index-meta-data-clean-up
Merged
Cleanup IndexMetaData#14119jasontedor merged 1 commit intoelastic:masterfrom jasontedor:index-meta-data-clean-up
jasontedor merged 1 commit intoelastic:masterfrom
jasontedor:index-meta-data-clean-up
Conversation
This commit cleans up IndexMetaData. In particular, all duplicate getters (X and getX) have been collapsed into one (getX). Further, the number of shards and number of replicas settings are now parsed once and saved off as fields.
Contributor
|
LGTM. I'm +1 on pushing this to 2.x and 2.1 |
Member
Author
|
Integrated into master, 2.1 and 2.x. Thanks for reviewing @bleskes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit cleans up IndexMetaData. In particular, all duplicate
getters (X and getX) have been collapsed into one (getX). Further, the
number of shards and number of replicas settings are now parsed once
and saved off as fields.