Ensure searcher is release if wrapping fails#14107
Merged
s1monw merged 1 commit intoelastic:masterfrom Oct 14, 2015
Merged
Conversation
Today we leak an index searcher if we fail to wrap the seacher in IndexShard. This commit ensures that the seacher is released if the wrapper throws an exception. This commit also restructures some test to be more atomic and only test a single feature / attribute of the wrapper.
Contributor
|
👍 |
s1monw
added a commit
that referenced
this pull request
Oct 14, 2015
…lure Ensure searcher is release if wrapping fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today we leak an index searcher if we fail to wrap the seacher in
IndexShard. This commit ensures that the seacher is released if the wrapper
throws an exception.
This commit also restructures some test to be more atomic and only test a single
feature / attribute of the wrapper.