Fixed a bug in logsdb rolling upgrade sereverless tests involving par…#141022
Merged
Kubik42 merged 2 commits intoelastic:mainfrom Jan 21, 2026
Merged
Conversation
5ec90b8 to
4a49c2a
Compare
…ametrized tests not performing a rolling upgrade
4a49c2a to
0f7ad85
Compare
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Jan 21, 2026
Member
martijnvg
left a comment
There was a problem hiding this comment.
LGTM 👍 I just think we need to make a modification to make this work for serverless CI.
...Test/java/org/elasticsearch/xpack/logsdb/AbstractStringTypeLogsdbRollingUpgradeTestCase.java
Outdated
Show resolved
Hide resolved
4834d21 to
4176457
Compare
9f7f099 to
3fa836e
Compare
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Jan 21, 2026
…-tests * upstream/main: (104 commits) Partition time-series source (elastic#140475) Mute org.elasticsearch.xpack.esql.heap_attack.HeapAttackSubqueryIT testManyRandomKeywordFieldsInSubqueryIntermediateResultsWithSortManyFields elastic#141083 Reindex relocation: skip nodes marked for shutdown (elastic#141044) Make fails on fixture caching not fail image building (elastic#140959) Add multi-project tests for get and list reindex (elastic#140980) Painless docs overhaul (reference) (elastic#137211) Panama vector implementation of codePointCount (elastic#140693) Enable PromQL in release builds (elastic#140808) Update rest-api-spec for Jina embedding task (elastic#140696) [CI] ShardSearchPhaseAPMMetricsTests testUniformCanMatchMetricAttributesWhenPlentyOfDocumentsInIndex failed (elastic#140848) Combine hash computation with bloom filter writes/reads (elastic#140969) Refactor posting iterators to provide more information (elastic#141058) Wait for cluster to recover to yellow before checking index health (elastic#141057) (elastic#141065) Fix repo analysis read count assertions (elastic#140994) Fixed a bug in logsdb rolling upgrade sereverless tests involving par… (elastic#141022) Fix readiness edge case on startup (elastic#140791) PromQL: fix quantile function (elastic#141033) ignore `mmr` command for check (in development) (elastic#140981) Use Double.compare to compare doubles in tdigest.Sort (elastic#141049) Migrate third party module tests using legacy test clusters framework (elastic#140991) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parametrized tests reuse the
clusterdefined in the parent class. This means that every test case beyond the first doesn't actually perform a rolling upgrade, but rather starts from an upgraded state.This PR addresses that. It removes
@ParameterFactoryand replaces it withgetTemplates(). The parent class callsgetTemplates()to perform indexing and verifications for each template at every stage of the test. In other words, templates are all tested against an old cluster, then a mixed cluster, and finally an upgraded cluster.Furthermore, to prevent issues like this from happening again, I've added a cluster version check into the
@Beforecall.