Add yaml tests for reindex cancellation#140894
Merged
szybia merged 5 commits intoelastic:mainfrom Jan 22, 2026
Merged
Conversation
szybia
commented
Jan 19, 2026
...ement/src/internalClusterTest/java/org/elasticsearch/reindex/management/ReindexCancelIT.java
Show resolved
Hide resolved
...index-management/src/yamlRestTest/resources/rest-api-spec/test/reindex/30_cancel_reindex.yml
Show resolved
Hide resolved
3 tasks
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds YAML REST tests for the reindex cancellation feature to ensure proper format validation, test the REST layer, and establish backward compatibility format expectations.
Changes:
- Added comprehensive YAML REST tests covering successful cancellation, error scenarios, and task type validation
- Implemented capability support in the REST handler for feature detection
- Removed redundant Java integration tests that are now covered by YAML tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/reindex-management/src/yamlRestTest/resources/rest-api-spec/test/reindex/30_cancel_reindex.yml | New YAML test file with three test scenarios for reindex cancellation |
| modules/reindex-management/src/main/java/org/elasticsearch/reindex/management/RestCancelReindexAction.java | Added capability support method to REST handler |
| modules/reindex-management/src/internalClusterTest/java/org/elasticsearch/reindex/management/ReindexCancelIT.java | Removed Java tests now covered by YAML tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...index-management/src/yamlRestTest/resources/rest-api-spec/test/reindex/30_cancel_reindex.yml
Outdated
Show resolved
Hide resolved
PeteGillinElastic
approved these changes
Jan 19, 2026
Member
PeteGillinElastic
left a comment
There was a problem hiding this comment.
Thanks. Just one small suggestion.
...index-management/src/yamlRestTest/resources/rest-api-spec/test/reindex/30_cancel_reindex.yml
Show resolved
Hide resolved
...index-management/src/yamlRestTest/resources/rest-api-spec/test/reindex/30_cancel_reindex.yml
Show resolved
Hide resolved
…-tests * upstream/main: (104 commits) Partition time-series source (elastic#140475) Mute org.elasticsearch.xpack.esql.heap_attack.HeapAttackSubqueryIT testManyRandomKeywordFieldsInSubqueryIntermediateResultsWithSortManyFields elastic#141083 Reindex relocation: skip nodes marked for shutdown (elastic#141044) Make fails on fixture caching not fail image building (elastic#140959) Add multi-project tests for get and list reindex (elastic#140980) Painless docs overhaul (reference) (elastic#137211) Panama vector implementation of codePointCount (elastic#140693) Enable PromQL in release builds (elastic#140808) Update rest-api-spec for Jina embedding task (elastic#140696) [CI] ShardSearchPhaseAPMMetricsTests testUniformCanMatchMetricAttributesWhenPlentyOfDocumentsInIndex failed (elastic#140848) Combine hash computation with bloom filter writes/reads (elastic#140969) Refactor posting iterators to provide more information (elastic#141058) Wait for cluster to recover to yellow before checking index health (elastic#141057) (elastic#141065) Fix repo analysis read count assertions (elastic#140994) Fixed a bug in logsdb rolling upgrade sereverless tests involving par… (elastic#141022) Fix readiness edge case on startup (elastic#140791) PromQL: fix quantile function (elastic#141033) ignore `mmr` command for check (in development) (elastic#140981) Use Double.compare to compare doubles in tdigest.Sort (elastic#141049) Migrate third party module tests using legacy test clusters framework (elastic#140991) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes elastic/elasticsearch-team#2086