Refactor MV_UNION and MV_INTERSECTION to use abstract base class#140623
Merged
mridula-s109 merged 17 commits intoelastic:mainfrom Jan 21, 2026
Merged
Refactor MV_UNION and MV_INTERSECTION to use abstract base class#140623mridula-s109 merged 17 commits intoelastic:mainfrom
mridula-s109 merged 17 commits intoelastic:mainfrom
Conversation
ioanatia
reviewed
Jan 14, 2026
...g/elasticsearch/xpack/esql/expression/function/scalar/multivalue/AbstractMvSetOperation.java
Outdated
Show resolved
Hide resolved
...g/elasticsearch/xpack/esql/expression/function/scalar/multivalue/AbstractMvSetOperation.java
Outdated
Show resolved
Hide resolved
...g/elasticsearch/xpack/esql/expression/function/scalar/multivalue/AbstractMvSetOperation.java
Outdated
Show resolved
Hide resolved
...g/elasticsearch/xpack/esql/expression/function/scalar/multivalue/AbstractMvSetOperation.java
Outdated
Show resolved
Hide resolved
5 tasks
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Hi @mridula-s109, I've created a changelog YAML for you. |
mridula-s109
commented
Jan 20, 2026
markjhoy
approved these changes
Jan 20, 2026
Contributor
markjhoy
left a comment
There was a problem hiding this comment.
👍 Nice and clean. Looks good assuming all the previous tests all pass
spinscale
pushed a commit
to spinscale/elasticsearch
that referenced
this pull request
Jan 21, 2026
…stic#140623) * Cleaned up using base class implementation * PR comments addressed * [CI] Auto commit changes from spotless * Removed redundant code * Refactored * Update docs/changelog/140623.yaml * [CI] Auto commit changes from spotless * Delete docs/changelog/140623.yaml --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #139982.
This PR extracts common set operation logic into a abstract class to reduce code duplication between MV_UNION and MV_INTERSECTION.