Skip to content

Fix EXTENDED_DOC_VALUES_PARAMS test cluster feature flag.#140519

Merged
martijnvg merged 4 commits intoelastic:mainfrom
martijnvg:extended_doc_values_params_impr
Jan 13, 2026
Merged

Fix EXTENDED_DOC_VALUES_PARAMS test cluster feature flag.#140519
martijnvg merged 4 commits intoelastic:mainfrom
martijnvg:extended_doc_values_params_impr

Conversation

@martijnvg
Copy link
Copy Markdown
Member

And use it in x-pack yaml integration test.

@martijnvg martijnvg added >test Issues or PRs that are addressing/adding tests :StorageEngine/Mapping The storage related side of mappings labels Jan 12, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@martijnvg martijnvg added the test-release Trigger CI checks against release build label Jan 12, 2026
Copy link
Copy Markdown
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, it is great. I think we should add test-release to this PR to be sure of it.

path: /_query
parameters: [ ]
capabilities: [ extended_doc_values_params ]
cluster_features: ["mapper.keyword.high_cardinality_length_function_fuse_to_load"]
Copy link
Copy Markdown
Contributor

@craigtaverner craigtaverner Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? How does it connect to extended_doc_values_options_feature_flag_enabled?

Copy link
Copy Markdown
Contributor

@craigtaverner craigtaverner Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I spoke too soon. The line in XPackRestIT turns on this feature for all tests, so we no longer need to have a condition here related to the extended doc values params.

Copy link
Copy Markdown
Member Author

@martijnvg martijnvg Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't, the feature flag is now always set for test clusters in release builds.

@martijnvg martijnvg enabled auto-merge (squash) January 12, 2026 15:58
Copy link
Copy Markdown
Contributor

@jordan-powers jordan-powers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martijnvg
Copy link
Copy Markdown
Member Author

The release-tests checkPart3 fail because of the same reason that was reported here: #140388 (comment)

I will merge this PR.

@martijnvg martijnvg disabled auto-merge January 13, 2026 07:47
@martijnvg martijnvg merged commit cf81aeb into elastic:main Jan 13, 2026
36 of 39 checks passed
eranweiss-elastic pushed a commit to eranweiss-elastic/elasticsearch that referenced this pull request Jan 15, 2026
spinscale pushed a commit to spinscale/elasticsearch that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants