ES|QL reenable SampleGenerator#140249
Merged
jan-elastic merged 2 commits intoelastic:mainfrom Jan 8, 2026
Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
luigidellaquila
approved these changes
Jan 7, 2026
Member
luigidellaquila
left a comment
There was a problem hiding this comment.
Thanks @jan-elastic, the fix is what I expected, my understanding is that the assert is no longer accurate when we have SAMPLE logic.
Please wait for Nhat's review though, as he is more familiar than me with that code.
Collaborator
💚 Backport successful
|
jan-elastic
added a commit
to jan-elastic/elasticsearch
that referenced
this pull request
Jan 8, 2026
* remove bad/old assertion * reenable ES|QL SampleGenerator tests
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #135336