Skip to content

Refactor MockAllocationService constructor#140153

Merged
elasticsearchmachine merged 28 commits intoelastic:mainfrom
ywangd:refactor-MockAllocationService
Jan 6, 2026
Merged

Refactor MockAllocationService constructor#140153
elasticsearchmachine merged 28 commits intoelastic:mainfrom
ywangd:refactor-MockAllocationService

Conversation

@ywangd
Copy link
Copy Markdown
Member

@ywangd ywangd commented Jan 5, 2026

This PR makes MockAllocationService constructor take an explicit ShardRoutingRoleStrategy parameter so that it can be customized.

Relates: #138333

ywangd added 27 commits November 20, 2025 00:22
@ywangd
Refactor SnapshotResiliencyTests to make it extendable to stateless
be339bf 
Also expand DeterministicTaskQueue
@ywangd
Add support for search node and search shard
1a78a34
@ywangd
license header
e310b57
@ywangd
Merge remote-tracking branch 'origin/main' into extend-snapshot-resil…
4c7b99e 
…iency-tests-to-stateless
@ywangd
Merge remote-tracking branch 'origin/main' into extend-snapshot-resil…
a6a8708 
…iency-tests-to-stateless
@ywangd
revert changes for DeterministicTaskQueue
4a016bf
@ywangd
Use direct executor
e979538
@ywangd
fix reconfigurator
9c42bda
@ywangd
fix number of default shards
cb28156
@ywangd
fix wait for green after restore
2786565
@ywangd
adapt for async translog upload
3bd2adc
@ywangd
fix testSuccessfulSnapshotWithConcurrentDynamicMappingUpdates
c129b32
@ywangd
fix testSnapshotDeleteWithMasterFailover
c3e7b07
@ywangd
Expand warning headers for merge scheduler
d710ad0
@ywangd
add stateless variant branch for testSnapshotPrimaryRelocations
9226f1c
@ywangd
Fix restart by creating node of the right subclass.
2bc9639 
Also support waiting for a condition before starting the restart node.
@ywangd
Merge remote-tracking branch 'origin/main' into extend-snapshot-resil…
9143f32 
…iency-tests-to-stateless
@ywangd
tweak for less change
14290c9
@ywangd
Remove extension points and allow the ThreadPool itself to be subclassed
f65346b
@ywangd
Ensure threadContext is preserved for all tasks
feab33a
@ywangd
Merge remote-tracking branch 'origin/main' into extend-snapshot-resil…
7a48938 
…iency-tests-to-stateless
@ywangd
add test for threadcontext preserve
2ad3965
@ywangd
tweak
7065937
@ywangd
space
64df44b
@ywangd
Merge remote-tracking branch 'origin/main' into split-extend-snapshot…
2ecdea3 
…-resiliency-tests-to-stateless
@ywangd
remove unwanted changes
cedef9f
@ywangd
Refactor MockAllocationService constructor
81c7202 
This PR makes MockAllocationService constructor take an explicit
ShardRoutingRoleStrategy parameter so that it can be customized.

Relates: elastic#138333
@ywangd ywangd requested a review from DaveCTurner January 5, 2026 08:04
@ywangd ywangd added >test Issues or PRs that are addressing/adding tests :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) labels Jan 5, 2026
@ywangd ywangd added the v9.4.0 label Jan 5, 2026
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination (obsolete) Meta label for Distributed Coordination team. Obsolete. Please do not use. label Jan 5, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Jan 5, 2026

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@ywangd ywangd mentioned this pull request Jan 5, 2026
Merged
DaveCTurner
DaveCTurner approved these changes Jan 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Jan 5, 2026
@ywangd ywangd added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 5, 2026
@elasticsearchmachine elasticsearchmachine merged commit de0fb74 into elastic:main Jan 6, 2026
36 checks passed
@ywangd ywangd deleted the refactor-MockAllocationService branch January 6, 2026 00:32
breskeby pushed a commit to breskeby/elasticsearch that referenced this pull request Feb 11, 2026
@ywangd
Cascading changes for MockAllocationService constructor (elastic#5169)
10990d5 
Depends on elastic#140153
breskeby pushed a commit to breskeby/elasticsearch that referenced this pull request Feb 11, 2026
@ywangd
Cascading changes for MockAllocationService constructor (elastic#5169)
ae21af3 
Depends on elastic#140153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) serverless-linked Added by automation, don't add manually Team:Distributed Coordination (obsolete) Meta label for Distributed Coordination team. Obsolete. Please do not use. >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ywangd @elasticsearchmachine @DaveCTurner