Skip to content

Delegate to ES93ScalarQuantizedVectorsFormat rather than copying behaviour#139834

Merged
thecoop merged 5 commits intoelastic:mainfrom
thecoop:consolidate-scalar-quantized-formats
Jan 7, 2026
Merged

Delegate to ES93ScalarQuantizedVectorsFormat rather than copying behaviour#139834
thecoop merged 5 commits intoelastic:mainfrom
thecoop:consolidate-scalar-quantized-formats

Conversation

@thecoop
Copy link
Copy Markdown
Member

@thecoop thecoop commented Dec 19, 2025

ES93HnswScalarQuantizedVectorsFormat copies the quantization implementation from ES93ScalarQuantizedVectorsFormat rather than delegating to it. The only reason for this is to not introduce an extra delegate wrapper in the reader - the flat format adds a search implementation. But this isn't actually called from the Lucene HNSW reader, so its ok to just use the scalar quantization format directly rather than copying its implementation

@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.4.0 labels Dec 19, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Copy Markdown
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thecoop my only concern is that we have adequate test coverage just incase this screws up named loading for quantization values on existing indices.

Maybe we are handled ok in our new rolling upgrade tests? Could you verify?

@thecoop
Copy link
Copy Markdown
Member Author

thecoop commented Jan 7, 2026

Yes, this is exactly the sort of thing DenseVectorRollingUpgradeIT tests - that indices created on previous versions can be opened and read by the current version

@thecoop thecoop merged commit dea9bb7 into elastic:main Jan 7, 2026
37 checks passed
@thecoop thecoop deleted the consolidate-scalar-quantized-formats branch January 7, 2026 16:40
szybia added a commit to szybia/elasticsearch that referenced this pull request Jan 7, 2026
* upstream/main:
  Add hook for blocking termination (elastic#133555)
  Delegate to ES93ScalarQuantizedVectorsFormat rather than copying behaviour (elastic#139834)
  Refactor compound block types (elastic#140219)
  Flush the rate buffer when the slice index changes (elastic#138856)
  Log linked project connection errors at debug during shutdown (elastic#140239)
  Periodic FIPS 140-3 buildkite pipelines (elastic#139909)
  ES|QL - Remove TERM function (elastic#139953)
  Fix name of started time field in shutdown status (elastic#139910)
  Drop `project_routing` from query params (elastic#140272)
  Fix flaky test: AllocationDecidersTests (elastic#140271)
  Add List Reindex API (elastic#140184)
  Expose _tier metadata attribute in ESQL (elastic#139894)
  Tweak TSDBRestEsqlIT#testTimeSeriesQuerying(...) (elastic#140210)
  Fix an OOM error when creating to many chained synonym graph token filter. (elastic#140026)
  Suppress Azure SDK error logs (elastic#139730)
  Rewritten integer sorts need to use SortedNumericSortField (elastic#139538) (elastic#139700)
  Adjust index versions for skippers for time series (elastic#139670)
  Fix host.name skippers index version range (elastic#139636)
  Remove BWC shim for a broken commit
  Fix index.mapping.use_doc_values_skipper defaults in serverless (elastic#139532)
sidosera pushed a commit to sidosera/elasticsearch that referenced this pull request Jan 7, 2026
thecoop added a commit to thecoop/elasticsearch that referenced this pull request Jan 30, 2026
thecoop added a commit to thecoop/elasticsearch that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>refactoring :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants