Add ESQL View as an IndexAbstraction#139778
Merged
dakrone merged 6 commits intoelastic:mainfrom Jan 2, 2026
Merged
Conversation
6434f70 to
4a43dd1
Compare
03d42b6 to
4656e6d
Compare
This commit adds the `View` class as the fourth `IndexAbstraction`. This means that it can be "resolved" in the expression resolver, and moves us towards implementing the ES security model for views. It also includes code that prevents conflicting views, indices, aliases, and data streams with the same name. Additionally, we prevent indexing into a view or directly resolving it for a search (if someone searches for `*` for instance). Relates to elastic#137818
4656e6d to
c0316f7
Compare
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
gmarouli
approved these changes
Dec 31, 2025
| assertThat( | ||
| e.getMessage(), | ||
| equalTo("Invalid alias name [logs]: an index or data stream exists with the same name as the alias") | ||
| equalTo("Invalid alias name [logs]: an index, data stream, or ESQL view exists with the same name as the alias") |
Contributor
There was a problem hiding this comment.
Nit: considering that this is a user facing message, do we need to write ES|QL instead of ESQL?
Member
Author
There was a problem hiding this comment.
I've seen a mixture of both in the codebase, but I found more using "ESQL" than "ES|QL", so I went with this one.
server/src/main/java/org/elasticsearch/cluster/metadata/ProjectMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/IndexNameExpressionResolver.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/IndexAbstraction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/View.java
Outdated
Show resolved
Hide resolved
| throw new IllegalArgumentException("cannot add view, the maximum number of views is reached: " + this.maxViewsCount); | ||
| } | ||
|
|
||
| final Map<String, IndexAbstraction> indicesLookup = getIndicesLookup(metadata); |
Contributor
There was a problem hiding this comment.
I see this logic is used to check naming collision for views against all other types. Why can't we use it elsewhere? I wonder if it could be a method in ProjectMetadata....that would make also collision logic easier to test.
Member
Author
There was a problem hiding this comment.
I opened #140131 for tracking unifying the name collision work. I agree that it definitely can be improved in subsequent work.
craigtaverner
approved these changes
Jan 2, 2026
Contributor
craigtaverner
left a comment
There was a problem hiding this comment.
Nice improvement. Great that name conflict checks appear to be implemented in both directions. There was a loose end in the TestCluster around wiping views, but other than that this looks good to me.
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/view/RestPutViewAction.java
Show resolved
Hide resolved
x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/esql/200_view.yml
Show resolved
Hide resolved
samxbr
pushed a commit
to samxbr/elasticsearch
that referenced
this pull request
Jan 5, 2026
* Add ESQL View as an IndexAbstraction This commit adds the `View` class as the fourth `IndexAbstraction`. This means that it can be "resolved" in the expression resolver, and moves us towards implementing the ES security model for views. It also includes code that prevents conflicting views, indices, aliases, and data streams with the same name. Additionally, we prevent indexing into a view or directly resolving it for a search (if someone searches for `*` for instance). Relates to elastic#137818 * Include views in comment * Add earlier filtering of views in IndexNameExpressionResolver * Use empty list of indices and null write index for View
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the
Viewclass as the fourthIndexAbstraction. This means that it can be"resolved" in the expression resolver, and moves us towards implementing the ES security model for
views. It also includes code that prevents conflicting views, indices, aliases, and data streams
with the same name. Additionally, we prevent indexing into a view or directly resolving it for a
search (if someone searches for
*for instance).Relates to #137818