Skip to content

ES|QL: Implement AllSupportedFieldsTestCase for TDigest and Histogram#139744

Merged
JonasKunz merged 3 commits intoelastic:mainfrom
JonasKunz:tdigest-allsupportedfieldstestcase2
Dec 19, 2025
Merged

ES|QL: Implement AllSupportedFieldsTestCase for TDigest and Histogram#139744
JonasKunz merged 3 commits intoelastic:mainfrom
JonasKunz:tdigest-allsupportedfieldstestcase2

Conversation

@JonasKunz
Copy link
Copy Markdown
Contributor

@JonasKunz JonasKunz commented Dec 18, 2025

Adds TDigest to the AllSupportedFieldsTestCase as a new type that has been added to both ES|QL and ES.
The feature flag for both were lifted in #139607.

In addition fixes the AllSupportedFieldsTestCase for histogram: That field existed prior to the release of ES|QL, but dedicated support for it was only added recently in #139703.

@JonasKunz JonasKunz added :Analytics/ES|QL AKA ESQL test-release Trigger CI checks against release build labels Dec 18, 2025
@nielsbauman
Copy link
Copy Markdown
Contributor

nielsbauman commented Dec 18, 2025

Hi @JonasKunz, I keep getting failures like

java.lang.AssertionError: unsupported field type [HISTOGRAM]	
at __randomizedtesting.SeedInfo.seed([6715BCF6C5872B6B:8EF770CFE0C14EF2]:0)	
at org.elasticsearch.xpack.esql.qa.rest.AllSupportedFieldsTestCase.expectedValue(AllSupportedFieldsTestCase.java:938)	
at org.elasticsearch.xpack.esql.qa.rest.AllSupportedFieldsTestCase.allTypesValuesMatcher(AllSupportedFieldsTestCase.java:388)	
at org.elasticsearch.xpack.esql.qa.rest.AllSupportedFieldsTestCase.doTestFetchAll(AllSupportedFieldsTestCase.java:310)	
at org.elasticsearch.xpack.esql.qa.rest.AllSupportedFieldsTestCase.testFetchAll(AllSupportedFieldsTestCase.java:256)

on my PR with test-release enabled, see this build for example:
https://gradle-enterprise.elastic.co/s/fi33zeg4vf4rq/tests/task/:x-pack:plugin:esql:qa:server:single-node:javaRestTest/details/org.elasticsearch.xpack.esql.qa.single_node.AllSupportedFieldsIT/testFetchAll%20%7Bpref=NONE%20mode=standard%7D?top-execution=1

This PR looks related. Are you planning on merging this soon? Otherwise I'm going to open an issue and mute the test.

@JonasKunz JonasKunz marked this pull request as ready for review December 18, 2025 14:43
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 18, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Dec 18, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

@JonasKunz
Copy link
Copy Markdown
Contributor Author

JonasKunz commented Dec 18, 2025

@nielsbauman yeah the test was broken for HISTOGRAM, which is fixed by this PR.
I'm hoping to merge this soon, but if you're blocked feel free to mute the test.

I encountered this also a few days ago, in which case I just removed the test-release tag from my PR for the checks to become green again.

@JonasKunz JonasKunz added the >test Issues or PRs that are addressing/adding tests label Dec 18, 2025
@JonasKunz JonasKunz requested a review from alex-spies December 18, 2025 14:45
@JonasKunz JonasKunz requested a review from nik9000 December 19, 2025 08:50
@nielsbauman nielsbauman mentioned this pull request Dec 19, 2025
Closed
@nielsbauman
Copy link
Copy Markdown
Contributor

nielsbauman commented Dec 19, 2025

Thanks @JonasKunz. I opened #139802 to mute the class for now, as I'd like a successful test-release build before merging.

alex-spies
alex-spies approved these changes Dec 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JonasKunz !

...qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/AllSupportedFieldsTestCase.java
@@ -976,7 +1005,7 @@ private static boolean supportedInEnrich(DataType t) {
// https://github.com/elastic/elasticsearch/issues/127350
case AGGREGATE_METRIC_DOUBLE, SCALED_FLOAT,
// https://github.com/elastic/elasticsearch/issues/139255
Copy link
Copy Markdown
Contributor

@alex-spies alex-spies Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need to update #139255. Left a comment there.

@JonasKunz JonasKunz merged commit 5176f2c into elastic:main Dec 19, 2025
36 checks passed
@JonasKunz JonasKunz mentioned this pull request Dec 19, 2025
Merged
szybia added a commit to szybia/elasticsearch that referenced this pull request Dec 19, 2025
@szybia
Merge remote-tracking branch 'upstream/main' into reindex-cancel-api
2d2c3da 
* upstream/main: (25 commits)
  Add spec for project routing CRUD REST API endpoints (elastic#139634)
  Implement AllSupportedFIeldsTestCase for TDigest (elastic#139744)
  Mute elastic#139802 (elastic#139803)
  fix(logsdb): batch bulk indexing to prevent OOM in challenge tests (elastic#139770)
  Documentation for semantic_text auto pre-filtering (elastic#139749)
  Always do bulk scoring for rescoring when possible (elastic#139777)
  Optimize script sorts that do not require query scores (elastic#139748)
  Bump versions after 9.1.9 release
  Update branches.json for 9.1.9 release
  Bump versions after 9.2.3 release
  Prune changelogs after 8.19.9 release
  Bump versions after 8.19.9 release
  Update branches.json for 8.19.9 release
  Finalize docs for v9.2.3 release (elastic#139795)
  ESQL: Added timezone support to date_format and date_parse (elastic#138517)
  Update branches.json for 9.2.3 release
  Finalize docs for v9.1.9 release (elastic#139796)
  Switch inline stats to GA in docs (elastic#139753)
  Validate license in CPS (elastic#139105)
  FIPS 140-3 support with BC FIPS 2.0.x (elastic#139319)
  ...
@not-napoleon not-napoleon mentioned this pull request Dec 19, 2025
Closed
JonasKunz added a commit to JonasKunz/elasticsearch that referenced this pull request Dec 19, 2025
@JonasKunz
Implement AllSupportedFIeldsTestCase for TDigest (elastic#139744)
c735838 
(cherry picked from commit 5176f2c)
@JonasKunz JonasKunz mentioned this pull request Dec 19, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Dec 19, 2025
@JonasKunz
Implement AllSupportedFIeldsTestCase for TDigest (#139744) (#139822)
9035d55 
(cherry picked from commit 5176f2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-spies alex-spies alex-spies approved these changes

@nik9000 nik9000 Awaiting requested review from nik9000

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v9.3.1 v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JonasKunz @nielsbauman @elasticsearchmachine @alex-spies