Larger offset when calculating the next histogram bucket to avoid col…#139675
Merged
elasticsearchmachine merged 4 commits intoelastic:mainfrom Dec 18, 2025
Merged
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Dec 17, 2025
| double minHistogramValue = randomDoubleBetween(0.0, 0.1, true); | ||
| for (int i = 0; i < array.length; i++) { | ||
| array[i] = minHistogramValue += randomDoubleBetween(0.0, 0.5, true); | ||
| array[i] = minHistogramValue += randomDoubleBetween(1.0, 10.0, true); |
kkrik-es
approved these changes
Dec 17, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Dec 18, 2025
elastic#139675) We generate legacy histograms in `DownsampleIT` and we used to small of a delta when generating the histogram values which caused them to collide. We ensure that the delta between the buckets is more than 1.0 fix that. Fixes elastic#139382 (cherry picked from commit 7ac049f) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 18, 2025
#139675) (#139737) We generate legacy histograms in `DownsampleIT` and we used to small of a delta when generating the histogram values which caused them to collide. We ensure that the delta between the buckets is more than 1.0 fix that. Fixes #139382 (cherry picked from commit 7ac049f) # Conflicts: # muted-tests.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We generate legacy histograms in
DownsampleITand we used to small of a delta when generating the histogram values which caused them to collide. We ensure that the delta between the buckets is more than 1.0 fix that.Fixes #139382