Fix FirstDocIdGroupingAggregatorFunction#139619
Merged
leontyevdv merged 3 commits intoelastic:mainfrom Dec 17, 2025
Merged
Conversation
Fix the algorithm of the doc collection. The wrong parameter has been passed to the shardRefCounted() method.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
approved these changes
Dec 16, 2025
Member
kkrik-es
left a comment
There was a problem hiding this comment.
What about testing? Anything we can do, maybe with one group and 3 shards?
Contributor
Author
Yes, of course! I've moved the PR to draft for now. I'm adding the tests. |
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Dec 17, 2025
…-err-message * upstream/main: (45 commits) Add sort field usage to telemetry (elastic#139530) ES|QL: Release CCS support for FORK (elastic#139630) Parameterize VectorSimilarityFunctionsTests on the similarity function (elastic#139516) fix broken links from ccs file move (elastic#139655) Update docs for v9.2.3 release (elastic#139479) Move tsdb bwc tests to x-pack/logsdb (elastic#139671) Fix FirstDocIdGroupingAggregatorFunction (elastic#139619) Fix release test for node_reduction profiling (elastic#139515) Unmute RestClientSingleHostIntegTests.testRequestResetAndAbort (elastic#139656) Unmute VerifyVersionConstantsIT.testLuceneVersionConstant (elastic#139644) Mute org.elasticsearch.repositories.gcs.GoogleCloudStorageBlobStoreRepositoryTests testReadNonExistingPath elastic#139665 Mute org.elasticsearch.smoketest.WatcherYamlRestIT test {p0=mustache/10_webhook/Test webhook action with mustache integration} elastic#139663 [ES|QL] Run aggregations on aggregate metric double with default metric (elastic#138647) Enable TDigest field mapper and ES|QL type (elastic#139607) Mute org.elasticsearch.index.mapper.HalfFloatSyntheticSourceNativeArrayIntegrationTests testSynthesizeArrayRandom elastic#139658 Explicitly cleanup test index with shared data path (elastic#136048) Mute org.elasticsearch.xpack.core.action.XPackUsageResponseTests testVersionDependentSerializationWriteToOldStream elastic#139576 Make XPackUsageResponseTests a wire serializing test case (elastic#139643) Mute org.elasticsearch.upgrades.UpgradeClusterClientYamlTestSuiteIT test {p0=mixed_cluster/90_ml_data_frame_analytics_crud/Start and stop old regression job} elastic#139654 Relax error bounds for RandomizedTimeSeriesIT (elastic#139641) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue can be found here: #139511
The docVector.shardRefCounted() method expects a position, not a shard number.