Skip to content

Remove ScriptEngineService.execute.#13956

Merged
jpountz merged 1 commit intoelastic:masterfrom
jpountz:remove/ScriptEngineService_execute
Oct 6, 2015
Merged

Remove ScriptEngineService.execute.#13956
jpountz merged 1 commit intoelastic:masterfrom
jpountz:remove/ScriptEngineService_execute

Conversation

@jpountz
Copy link
Copy Markdown
Contributor

@jpountz jpountz commented Oct 6, 2015

This methods was only used in tests and can be replaced by calling
ScriptEngineService.executable(compiledScript, vars).run() instead.

@jpountz jpountz added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Oct 6, 2015
@rjernst
Copy link
Copy Markdown
Member

rjernst commented Oct 6, 2015

I was always confused about the difference between execute and executable there. LGTM.

This methods was only used in tests and can be replaced by calling
`ScriptEngineService.executable(compiledScript, vars).run()` instead.
@jpountz jpountz force-pushed the remove/ScriptEngineService_execute branch from 887006f to 56c2c24 Compare October 6, 2015 11:53
jpountz added a commit that referenced this pull request Oct 6, 2015
…cute

Remove ScriptEngineService.execute.
@jpountz jpountz merged commit 07fe08f into elastic:master Oct 6, 2015
@jpountz jpountz deleted the remove/ScriptEngineService_execute branch October 6, 2015 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement v2.2.0 v5.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants