Fixed an edge case that forced some text fields to be stored in ignored source#139415
Merged
Kubik42 merged 3 commits intoelastic:mainfrom Dec 15, 2025
Merged
Conversation
Collaborator
|
Hi @Kubik42, I've created a changelog YAML for you. |
9f502c0 to
6a7e0ff
Compare
3827583 to
078f36b
Compare
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @Kubik42, I've created a changelog YAML for you. |
cbcdb9c to
f5de8e0
Compare
Collaborator
|
Hi @Kubik42, I've created a changelog YAML for you. |
1a047e1 to
cc13ebe
Compare
Kubik42
commented
Dec 14, 2025
|
|
||
| public void testStoreParameterDefaultsToFalseWithLatestIndexVersionWhenSyntheticSourceIsEnabled() throws IOException { | ||
| var indexSettings = getIndexSettingsBuilder().put(IndexSettings.INDEX_MAPPER_SOURCE_MODE_SETTING.getKey(), "synthetic").build(); | ||
| public void testStoring() throws IOException { |
Contributor
Author
There was a problem hiding this comment.
It looks like as though I changed a lot of the tests, but in reality the changes boil down to adding a few extra checks into the existing tests and renaming some things. These checks are:
- verifying that the field is stored in the way we expect it to (stored field, ignored source, fallback stored field, etc.)
- verifying that the field isn't being double stored
These additional checks aren't super sophisticated - I believe we should put more effort into them when we go full columnar.
parkertimmins
pushed a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Dec 17, 2025
…ed source (elastic#139415) * Removed the logic that defaults store to false in text fields * Fixed serverless issue * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #138796 we discovered a bug where due to this check, some text fields were being stored in ignored source. This was unintended.
Unfortunately, while 9.3 is not yet released, the bug is already in serverless. This PR aims to address that.
First, we're going to keep
storenew default as it makes fixing this bug easier. And second, we're going to apply an upper and lower index version check to still read ignored source in block loaders for indices created between when the bug was introduced and now.