Exclude patch versions from TransportVersionUtils#138997
Merged
mark-vieira merged 14 commits intoelastic:mainfrom Jan 5, 2026
Merged
Exclude patch versions from TransportVersionUtils#138997mark-vieira merged 14 commits intoelastic:mainfrom
mark-vieira merged 14 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jdconrad
reviewed
Dec 3, 2025
test/framework/src/main/java/org/elasticsearch/test/TransportVersionUtils.java
Outdated
Show resolved
Hide resolved
rjernst
reviewed
Dec 3, 2025
# Conflicts: # server/src/test/java/org/elasticsearch/TransportVersionTests.java
This was referenced Dec 18, 2025
jdconrad
approved these changes
Jan 5, 2026
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 5, 2026
(cherry picked from commit 08d3db4) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 5, 2026
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch versions break certain assumptions around temporality when comparing transport versions. For this reason, some tests that rely on methods in
TransportVersionUtilsmay begin to fail in the presence of patch versions. To avoid this, we simply exclude patch version when requesting a random version, as well as prohibit patch versions as bound arguments to these methods.Closes #139740
Closes #139741