install groovy plugin before running script test#13861
Merged
brwe merged 1 commit intoelastic:masterfrom Oct 6, 2015
Merged
Conversation
Member
|
Fine by me. I'll be happy when we have a scripting language enabled by default again! |
Contributor
Author
|
@nik9000 I messed something up while testing. Test don't actually pass yet with my fix, they just fail at a later stage. Sorry, I'll figure out what is wrong and update shortly... |
groovy moved to a plugin but the tests rely on it see elastic#13834
b85ed9c to
4d54e65
Compare
Contributor
Author
|
I know why the tests fail now. I made a pr here: #13933 Once this is in the vagrant tests all pass with this pr. |
4d54e65 to
b4350e3
Compare
brwe
added a commit
that referenced
this pull request
Oct 6, 2015
install groovy plugin before running script test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
groovy moved to a plugin but the tests rely on it
see #13834
I also wonder why we test scripting here at all.
@nik9000 can you take a look? also, sorry I did not run all test before #13856