[ES|QL] Support for First/Last (#137408) - Disable vector dispatch for blocks#138390
Merged
mouhc1ne merged 1 commit intoelastic:mainfrom Nov 24, 2025
Merged
Conversation
- Skip vector optimization for block arguments when grouping, to prevent grouping aggs from executing the no-op path.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
14 tasks
nik9000
reviewed
Nov 21, 2025
Member
nik9000
left a comment
There was a problem hiding this comment.
This removes the "Vector dispatch" for these Block-only aggs because it was a noop which is only correct for the spatial agg. For FIRST and LAST it should do something.
Our plan is to add a more controllable Vector dispatch back. For now the side effect is that these spatial aggs will slow down if sent vectors - which they can't work on anyway.
nik9000
reviewed
Nov 21, 2025
Member
nik9000
left a comment
There was a problem hiding this comment.
@craigtaverner should also double check, but it's good to me.
nik9000
approved these changes
Nov 21, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 26, 2025
- Skip vector optimization for block arguments when grouping, to prevent grouping aggs from executing the no-op path. - This path will be enabled back once an actual implementation is in place.
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Nov 26, 2025
- Skip vector optimization for block arguments when grouping, to prevent grouping aggs from executing the no-op path. - This path will be enabled back once an actual implementation is in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added to an item to #108385 's checklist to enable this back once a non-op vector implementation is added.