ESQL: Add exponential_histogram support to AVG and SUM#138177
Merged
JonasKunz merged 7 commits intoelastic:mainfrom Nov 20, 2025
Merged
ESQL: Add exponential_histogram support to AVG and SUM#138177JonasKunz merged 7 commits intoelastic:mainfrom
JonasKunz merged 7 commits intoelastic:mainfrom
Conversation
9c6f4c9 to
3e2ee1f
Compare
JonasKunz
commented
Nov 18, 2025
| Stream.of( | ||
| MultiRowTestCaseSupplier.intCases(1, 1000, Integer.MIN_VALUE, Integer.MAX_VALUE, true), | ||
| MultiRowTestCaseSupplier.aggregateMetricDoubleCases(1, 1000, -Double.MAX_VALUE, Double.MAX_VALUE) | ||
| MultiRowTestCaseSupplier.aggregateMetricDoubleCases(1, 1000, -Double.MAX_VALUE, Double.MAX_VALUE), |
Contributor
Author
There was a problem hiding this comment.
Info: This test made me notice that the unit tests unfortunately aren't that useful for surrogates, as we skip the evaluation for those.
Therefore we have to make sure that we really cover everything in the CSV tests.
17 tasks
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #137549.
There is still a TODO for AVG: For the edge case of empty histograms, this leads to
0.0 / 0.0, which in turn triggers a warning.I plan on solving this in a follow up PR by changing SUM to be defined as
nullinstead of0.0for empty histograms.