Wait for nodes to have downloaded databases in GeoIpDownloaderIT#137636
Merged
nielsbauman merged 2 commits intoelastic:mainfrom Nov 6, 2025
Merged
Wait for nodes to have downloaded databases in GeoIpDownloaderIT#137636nielsbauman merged 2 commits intoelastic:mainfrom
GeoIpDownloaderIT#137636nielsbauman merged 2 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
szybia
approved these changes
Nov 5, 2025
This was referenced Nov 6, 2025
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Nov 6, 2025
…lastic#137636) Some tests would move to the cleanup phase while the `DatabaseNodeService` instances on some nodes were still retrieving the databases asynchronously. This caused databases to be "loaded" after the filed were deleted, causing the cleanup to fail. This doesn't seem like a very realistic production scenario (deleting GeoIP database files milliseconds after new GeoIP processors were added), so we can simply make the test wait for all nodes to have loaded the database before moving on to the cleanup. See elastic#117219 (comment) for more information. Closes elastic#117219 Closes elastic#122683
Collaborator
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Nov 6, 2025
…lastic#137636) Some tests would move to the cleanup phase while the `DatabaseNodeService` instances on some nodes were still retrieving the databases asynchronously. This caused databases to be "loaded" after the filed were deleted, causing the cleanup to fail. This doesn't seem like a very realistic production scenario (deleting GeoIP database files milliseconds after new GeoIP processors were added), so we can simply make the test wait for all nodes to have loaded the database before moving on to the cleanup. See elastic#117219 (comment) for more information. Closes elastic#117219 Closes elastic#122683
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 6, 2025
…137636) (#137658) Some tests would move to the cleanup phase while the `DatabaseNodeService` instances on some nodes were still retrieving the databases asynchronously. This caused databases to be "loaded" after the filed were deleted, causing the cleanup to fail. This doesn't seem like a very realistic production scenario (deleting GeoIP database files milliseconds after new GeoIP processors were added), so we can simply make the test wait for all nodes to have loaded the database before moving on to the cleanup. See #117219 (comment) for more information. Closes #117219 Closes #122683
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 6, 2025
…137636) (#137659) Some tests would move to the cleanup phase while the `DatabaseNodeService` instances on some nodes were still retrieving the databases asynchronously. This caused databases to be "loaded" after the filed were deleted, causing the cleanup to fail. This doesn't seem like a very realistic production scenario (deleting GeoIP database files milliseconds after new GeoIP processors were added), so we can simply make the test wait for all nodes to have loaded the database before moving on to the cleanup. See #117219 (comment) for more information. Closes #117219 Closes #122683
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 6, 2025
…137636) (#137657) Some tests would move to the cleanup phase while the `DatabaseNodeService` instances on some nodes were still retrieving the databases asynchronously. This caused databases to be "loaded" after the filed were deleted, causing the cleanup to fail. This doesn't seem like a very realistic production scenario (deleting GeoIP database files milliseconds after new GeoIP processors were added), so we can simply make the test wait for all nodes to have loaded the database before moving on to the cleanup. See #117219 (comment) for more information. Closes #117219 Closes #122683
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 6, 2025
…lastic#137636) Some tests would move to the cleanup phase while the `DatabaseNodeService` instances on some nodes were still retrieving the databases asynchronously. This caused databases to be "loaded" after the filed were deleted, causing the cleanup to fail. This doesn't seem like a very realistic production scenario (deleting GeoIP database files milliseconds after new GeoIP processors were added), so we can simply make the test wait for all nodes to have loaded the database before moving on to the cleanup. See elastic#117219 (comment) for more information. Closes elastic#117219 Closes elastic#122683
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Nov 6, 2025
…-json
* upstream/main:
Mute org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterBasicLicenseIT testLicenseInvalidForInference {p0=false} elastic#137691
Mute org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterBasicLicenseIT testLicenseInvalidForInference {p0=true} elastic#137690
[LTR] Fix feature display order when using explain. (elastic#137671)
Remove extra RemoteClusterService instances in unit test (elastic#137647)
Fix `ComponentTemplatesFileSettingsIT.testSettingsApplied` (elastic#137669)
Consolidates troubleshooting content into the "Returning semantic field embeddings in _source" section (elastic#137233)
Update bundled JDK to 25.0.1 (elastic#137640)
resolve indices for prefixed _all expressions (elastic#137330)
ESQL: Add TopN support for exponential histograms (elastic#137313)
allows field caps to be cross project (elastic#137530)
ESQL: Add exponential histogram percentile function (elastic#137553)
Wait for nodes to have downloaded databases in `GeoIpDownloaderIT` (elastic#137636)
Tighten on when THROTTLE decision can be returned (elastic#136794)
Mute org.elasticsearch.xpack.esql.qa.single_node.GenerativeMetricsIT test elastic#137655
Add a test for two little known conditional processor paths (elastic#137645)
Extract a common ORIGIN constant (elastic#137612)
Remove early phase failure in batched (elastic#136889)
Returning correct index mode from get data streams api (elastic#137646)
[ML] Manage AD results indices (elastic#136065)
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Nov 6, 2025
…-json
* upstream/main:
Mute org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterBasicLicenseIT testLicenseInvalidForInference {p0=false} elastic#137691
Mute org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterBasicLicenseIT testLicenseInvalidForInference {p0=true} elastic#137690
[LTR] Fix feature display order when using explain. (elastic#137671)
Remove extra RemoteClusterService instances in unit test (elastic#137647)
Fix `ComponentTemplatesFileSettingsIT.testSettingsApplied` (elastic#137669)
Consolidates troubleshooting content into the "Returning semantic field embeddings in _source" section (elastic#137233)
Update bundled JDK to 25.0.1 (elastic#137640)
resolve indices for prefixed _all expressions (elastic#137330)
ESQL: Add TopN support for exponential histograms (elastic#137313)
allows field caps to be cross project (elastic#137530)
ESQL: Add exponential histogram percentile function (elastic#137553)
Wait for nodes to have downloaded databases in `GeoIpDownloaderIT` (elastic#137636)
Tighten on when THROTTLE decision can be returned (elastic#136794)
Mute org.elasticsearch.xpack.esql.qa.single_node.GenerativeMetricsIT test elastic#137655
Add a test for two little known conditional processor paths (elastic#137645)
Extract a common ORIGIN constant (elastic#137612)
Remove early phase failure in batched (elastic#136889)
Returning correct index mode from get data streams api (elastic#137646)
[ML] Manage AD results indices (elastic#136065)
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Nov 10, 2025
…lastic#137636) Some tests would move to the cleanup phase while the `DatabaseNodeService` instances on some nodes were still retrieving the databases asynchronously. This caused databases to be "loaded" after the filed were deleted, causing the cleanup to fail. This doesn't seem like a very realistic production scenario (deleting GeoIP database files milliseconds after new GeoIP processors were added), so we can simply make the test wait for all nodes to have loaded the database before moving on to the cleanup. See elastic#117219 (comment) for more information. Closes elastic#117219 Closes elastic#122683
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests would move to the cleanup phase while the
DatabaseNodeServiceinstances on some nodes were still retrieving the databases asynchronously. This caused databases to be "loaded" after the filed were deleted, causing the cleanup to fail.This doesn't seem like a very realistic production scenario (deleting GeoIP database files milliseconds after new GeoIP processors were added), so we can simply make the test wait for all nodes to have loaded the database before moving on to the cleanup.
See #117219 (comment)
for more information.
Closes #117219
Closes #122683