ESQL: Move doc values BlockLoader impls#137063
Merged
nik9000 merged 1 commit intoelastic:mainfrom Oct 23, 2025
Merged
Conversation
We have a bunch of these as inner classes. Some of them are inner classes of the field types they support - which is fine and good. But a bunch of the shared ones were inner classes of `BlockDocValuesReader` which made the class like a billion lines long. And it made it harder to find the source code of the shared ones because they weren't in alphabetical order. This moves these block loaders to top level classes. And lets our IDE put them in alphabetical order for us. Which is nice because we'll be adding a bunch more of them as we move further on elastic#137002.
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
dnhatn
approved these changes
Oct 23, 2025
Member
Author
|
Thanks @dnhatn ! |
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
We have a bunch of these as inner classes. Some of them are inner classes of the field types they support - which is fine and good. But a bunch of the shared ones were inner classes of `BlockDocValuesReader` which made the class like a billion lines long. And it made it harder to find the source code of the shared ones because they weren't in alphabetical order. This moves these block loaders to top level classes. And lets our IDE put them in alphabetical order for us. Which is nice because we'll be adding a bunch more of them as we move further on elastic#137002.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a bunch of these as inner classes. Some of them are inner classes of the field types they support - which is fine and good. But a bunch of the shared ones were inner classes of
BlockDocValuesReaderwhich made the class like a billion lines long. And it made it harder to find the source code of the shared ones because they weren't in alphabetical order.This moves these block loaders to top level classes. And lets our IDE put them in alphabetical order for us. Which is nice because we'll be adding a bunch more of them as we move further on #137002.