Fix inference operator circuit breaker tests#136870
Merged
afoucret merged 5 commits intoelastic:mainfrom Oct 21, 2025
Merged
Conversation
Contributor
afoucret
commented
Oct 21, 2025
- Fixes [CI] TextEmbeddingOperatorTests testSimpleCircuitBreaking failing #135569
- Fixes [CI] CompletionOperatorTests testSimpleCircuitBreaking failing #132382
- Fixes [CI] RerankOperatorTests testSimpleCircuitBreaking failing #133619
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
afoucret
commented
Oct 21, 2025
| }); | ||
| } | ||
|
|
||
| private void runWithRandomDelay(Runnable runnable) { |
Contributor
Author
There was a problem hiding this comment.
Previous implementation of runWithDelay was not really realistic:
- It was not always adding a delay which is never the case
- it was using the generic threadpool that can be saturated with inference request. Using a separate threadpool to execute inference looks more like the real implenentaion
afoucret
commented
Oct 21, 2025
| } | ||
|
|
||
| @Override | ||
| protected int largeInputSize() { |
Contributor
Author
There was a problem hiding this comment.
Set the size of large between 100 and 1000 which is more realistic for inference operation.
Veru big size like 10000 can create timeout that might make the CI flaky.
afoucret
commented
Oct 21, 2025
Comment on lines
+72
to
+87
| assertSimple(driverContext(), smallInputSize()); | ||
| } | ||
|
|
||
| protected int smallInputSize() { | ||
| return randomIntBetween(1, 100); | ||
| } | ||
|
|
||
| /** | ||
| * Test a larger input set against {@link #simple}. | ||
| */ | ||
| public final void testSimpleLargeInput() { | ||
| assertSimple(driverContext(), between(1_000, 10_000)); | ||
| assertSimple(driverContext(), largeInputSize()); | ||
| } | ||
|
|
||
| protected int largeInputSize() { | ||
| return randomIntBetween(1_000, 10_000); |
Contributor
Author
There was a problem hiding this comment.
Making size of small and large input configurable for operator tests. Kept the same default.
ioanatia
approved these changes
Oct 21, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Oct 22, 2025
afoucret
added a commit
that referenced
this pull request
Oct 22, 2025
chrisparrinello
pushed a commit
to chrisparrinello/elasticsearch
that referenced
this pull request
Oct 24, 2025
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
fzowl
pushed a commit
to voyage-ai/elasticsearch
that referenced
this pull request
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.