Skip to content

ES|QL: Fix decay tests#136401

Merged
ioanatia merged 5 commits intoelastic:mainfrom
ioanatia:decay_tests_fix
Oct 15, 2025
Merged

ES|QL: Fix decay tests#136401
ioanatia merged 5 commits intoelastic:mainfrom
ioanatia:decay_tests_fix

Conversation

@ioanatia
Copy link
Copy Markdown
Contributor

@ioanatia ioanatia commented Oct 10, 2025 •
edited
Loading

closes #135394
closes #135357
closes #134679
closes #134509
closes #134447

The tests had primarily 2 issues, all revolving the test cases where we generate random parameters for the Decay function:

  • sometimes the generated value was Infinity which isn't working well with the closeTo matcher
  • even if the actual and expected values are approximately the same, the closeTo assertions are still failing, so I am rounding the expected value to a few decimals.

@ioanatia ioanatia added >test Issues or PRs that are addressing/adding tests Team:Search - Relevance The Search organization Search Relevance team :Search Relevance/ES|QL Search functionality in ES|QL v9.3.0 labels Oct 10, 2025
@ioanatia ioanatia added auto-backport Automatically create backport pull requests when merged v9.2.0 labels Oct 13, 2025
@ioanatia ioanatia marked this pull request as ready for review October 13, 2025 07:10
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed Team:Search - Relevance The Search organization Search Relevance team labels Oct 13, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Oct 13, 2025

Pinging @elastic/es-search-relevance (Team:Search Relevance)

carlosdelest
carlosdelest approved these changes Oct 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 💯

@ioanatia ioanatia merged commit 4ccd68e into elastic:main Oct 15, 2025
34 checks passed
@ioanatia ioanatia deleted the decay_tests_fix branch October 15, 2025 08:59
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Oct 15, 2025

💔 Backport failed

Status Branch Result
❌ 9.2 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 136401

@ioanatia ioanatia removed backport pending auto-backport Automatically create backport pull requests when merged v9.2.0 labels Oct 15, 2025
Kubik42 pushed a commit to Kubik42/elasticsearch that referenced this pull request Oct 16, 2025
@ioanatia @Kubik42
ES|QL: Fix decay tests (elastic#136401)
1bd5528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment