Skip to content

Remove trace logger in entitlements transformer on default path#136152

Merged
mosche merged 2 commits intoelastic:mainfrom
mosche:entitlements/fix_JULBridgeTests
Oct 8, 2025
Merged

Remove trace logger in entitlements transformer on default path#136152
mosche merged 2 commits intoelastic:mainfrom
mosche:entitlements/fix_JULBridgeTests

Conversation

@mosche
Copy link
Copy Markdown
Contributor

@mosche mosche commented Oct 8, 2025

Remove trace logger in Transformer on the default path when a class doesn't need to be transformed.

This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender.

Fixes #132280

mosche added 2 commits October 8, 2025 08:28
…'t need to be transformed.

This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender.

Fixes elastic#132280
@mosche mosche requested a review from rjernst October 8, 2025 06:30
@mosche mosche requested a review from a team as a code owner October 8, 2025 06:30
@mosche mosche added >non-issue :Core/Infra/Entitlements Entitlements infrastructure labels Oct 8, 2025
@elasticsearchmachine elasticsearchmachine added v9.3.0 Team:Core/Infra Meta label for core/infra team labels Oct 8, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosche mosche merged commit 2858d6a into elastic:main Oct 8, 2025
34 checks passed
@mamazzol mamazzol added auto-backport Automatically create backport pull requests when merged branch:9.2 branch:9.1 labels Dec 8, 2025
mamazzol pushed a commit to mamazzol/elasticsearch that referenced this pull request Dec 8, 2025
…'t need to be transformed. (elastic#136152)

This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender.

Fixes elastic#132280

(cherry picked from commit 2858d6a)
@mamazzol
Copy link
Copy Markdown
Contributor

mamazzol commented Dec 8, 2025

💚 All backports created successfully

Status Branch Result
9.2
9.1

Questions ?

Please refer to the Backport tool documentation

@mamazzol mamazzol removed the auto-backport Automatically create backport pull requests when merged label Dec 8, 2025
mamazzol pushed a commit to mamazzol/elasticsearch that referenced this pull request Dec 8, 2025
…'t need to be transformed. (elastic#136152)

This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender.

Fixes elastic#132280

(cherry picked from commit 2858d6a)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Dec 8, 2025
…'t need to be transformed. (#136152) (#139184)

This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender.

Fixes #132280

(cherry picked from commit 2858d6a)

Co-authored-by: Moritz Mack <mmack@apache.org>
elasticsearchmachine pushed a commit that referenced this pull request Dec 8, 2025
…'t need to be transformed. (#136152) (#139185)

This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender.

Fixes #132280

(cherry picked from commit 2858d6a)

# Conflicts:
#	muted-tests.yml

Co-authored-by: Moritz Mack <mmack@apache.org>
mosche added a commit to mosche/elasticsearch that referenced this pull request Feb 26, 2026
…'t need to be transformed. (elastic#136152)

This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender.

Fixes elastic#132280

(cherry picked from commit 2858d6a)

# Conflicts:
#	muted-tests.yml
@mosche
Copy link
Copy Markdown
Contributor Author

mosche commented Feb 26, 2026

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Feb 26, 2026
…'t need to be transformed. (#136152) (#143138)

This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender.

Fixes #132280

(cherry picked from commit 2858d6a)

# Conflicts:
#	muted-tests.yml
neilbhavsar pushed a commit that referenced this pull request Feb 27, 2026
…'t need to be transformed. (#136152) (#143138)

This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender.

Fixes #132280

(cherry picked from commit 2858d6a)

# Conflicts:
#	muted-tests.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] JULBridgeTests testThrowable failing

4 participants