network.host must be set for discovery-ec2 plugin#13602
Merged
dadoonet merged 1 commit intoelastic:masterfrom Oct 6, 2015
Merged
network.host must be set for discovery-ec2 plugin#13602dadoonet merged 1 commit intoelastic:masterfrom
dadoonet merged 1 commit intoelastic:masterfrom
Conversation
Contributor
Author
|
@clintongormley Could you review this please? |
docs/plugins/discovery-ec2.asciidoc
Outdated
Contributor
Author
There was a problem hiding this comment.
Should be here: discovery-ec2-network-host
5d83a43 to
a986101
Compare
docs/plugins/discovery-ec2.asciidoc
Outdated
Contributor
There was a problem hiding this comment.
maybe just "equivalent to _ec2:privateIpv4_"?
Contributor
|
LGTM |
a986101 to
640a223
Compare
With 2.0, we now bind to `localhost` by default instead of binding to the network card and use its IP address. When the discovery plugin gets from AWS API the list of nodes that should form the cluster, this list is pinged then. But as each node is bound to `localhost`, ping does not get an answer and the node elects itself as the master node. `network.host` must be set. Closes elastic#13589.
640a223 to
685c1f4
Compare
dadoonet
added a commit
that referenced
this pull request
Oct 6, 2015
Related to #13602 (cherry picked from commit ff4cdab)
dadoonet
added a commit
that referenced
this pull request
Oct 6, 2015
Related to #13602 (cherry picked from commit ff4cdab) (cherry picked from commit 8b46a4b)
dadoonet
added a commit
that referenced
this pull request
Oct 6, 2015
Related to #13602 (cherry picked from commit ff4cdab) (cherry picked from commit 8b46a4b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 2.0, we now bind to
localhostby default instead of binding to the network card and use its IP address.When the discovery plugin gets from AWS API the list of nodes that should form the cluster, this list is pinged then. But as each node is bound to
localhost, ping does not get an answer and the node elects itself as the master node.network.hostmust be set.Closes #13589.