Fix blob size in writeBlob() method#13574
Merged
tlrx merged 1 commit intoelastic:masterfrom Sep 30, 2015
Merged
Conversation
5 tasks
Contributor
There was a problem hiding this comment.
The first condition seems to be redundant, but it might be ok to leave it in for clarity.
Contributor
|
Great catch! I wonder if it might make more sense to move this logic into fileInfo. So |
Member
Author
Contributor
There was a problem hiding this comment.
Maybe length() % partBytes?
Contributor
|
Left one minor comment. LGTM. |
4c4bfb6 to
d715dfd
Compare
s1monw
added a commit
that referenced
this pull request
Sep 30, 2015
s1monw
added a commit
that referenced
this pull request
Sep 30, 2015
s1monw
added a commit
that referenced
this pull request
Sep 30, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that #13434 computes a wrong blob size when writing snapshot files.
@imotov Can you please have a look?