Remove logging of trusted system classes to not risk causing ClassCircularityError#134431
Merged
mosche merged 2 commits intoelastic:mainfrom Sep 10, 2025
Merged
Conversation
…cularityError. We've seen this previously (and predictably) in elastic#131539 due to logging Exceptions in isTriviallyAllowed. elastic#133269 shows exactly the same symptoms. Fixes elastic#133269 Fixes elastic#133267 Fixes elastic#133268
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
approved these changes
Sep 10, 2025
Contributor
ldematte
left a comment
There was a problem hiding this comment.
I was going to do this, I noticed the great number debug logs while debugging something else.
Thanks for addressing this!
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Sep 10, 2025
…cularityError. (elastic#134431) We've seen this previously (and predictably) in elastic#131539 due to logging Exceptions in isTriviallyAllowed. elastic#133269 shows exactly the same symptoms. Fixes elastic#133269 Fixes elastic#133267 Fixes elastic#133268
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Sep 10, 2025
…cularityError. (elastic#134431) We've seen this previously (and predictably) in elastic#131539 due to logging Exceptions in isTriviallyAllowed. elastic#133269 shows exactly the same symptoms. Fixes elastic#133269 Fixes elastic#133267 Fixes elastic#133268
This was referenced Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen this previously (and predictably) in #131539 due to logging Exceptions in isTriviallyAllowed. #133269 shows exactly the same symptoms.
Note: The changes in ClusterSettingsIT are not necessary, but setting the root log level to TRACE causes a flood of logs - which is a bit unnecessary.
Fixes #133269
Fixes #133267
Fixes #133268