Skip to content

Unmute CCSDuelIT_testTerminateAfter test#132648

Merged
drempapis merged 2 commits intoelastic:mainfrom
drempapis:test-failure/CCSDuelIT_testTerminateAfter
Aug 11, 2025
Merged

Unmute CCSDuelIT_testTerminateAfter test#132648
drempapis merged 2 commits intoelastic:mainfrom
drempapis:test-failure/CCSDuelIT_testTerminateAfter

Conversation

@drempapis
Copy link
Copy Markdown
Contributor

@drempapis drempapis commented Aug 11, 2025 •
edited
Loading

I removed the "terminated_early" from the responseToMap(...); This is a best-effort, transport metadata, and removing it only affects the local comparison map, not the server response, and none of the tests assert on that flag. The intent of all the tests in the class is preserved. If we ever need to test terminated_early explicitly, that should be a separate, targeted test, not this CCS duel.

Closes 126085

@drempapis drempapis added >test Issues or PRs that are addressing/adding tests Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations labels Aug 11, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Aug 11, 2025

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@pawankartik-elastic
Copy link
Copy Markdown
Contributor

pawankartik-elastic commented Aug 11, 2025

Could you help me understand how its presence causes the test to fail and get muted?

@drempapis
Copy link
Copy Markdown
Contributor Author

drempapis commented Aug 11, 2025 •
edited
Loading

@pawankartik-elastic Please address the assertion error mentioned in the reported ticket. The failure occurs when terminated_early does not match.

java.lang.AssertionError: Comparing async_search minimizeRoundTrip vs. fanOut. Didn't match expected value. /terminated_early: the elements don't match: [true] != [false].
Full diff                      _clusters: 
                         details: 
                 my_remote_cluster: 
                             _shards: 
                                failed: same [0]
                               skipped: same [0]
                            successful: same [5]
                                 total: same [5]
                             indices: same [ccs_duel_index]
                              status: same [successful]
                           timed_out: same [false]
                                took: same [-1]
                          failed: same [0]
                         partial: same [0]
                         running: same [0]
                         skipped: same [0]
                      successful: same [1]
                           total: same [1]
     
[truncated]

@smalyshev
Copy link
Copy Markdown
Contributor

smalyshev commented Aug 11, 2025

We may want to backport it since the original issue is on 8.19

@drempapis
Copy link
Copy Markdown
Contributor Author

drempapis commented Aug 11, 2025

Thank you both!

@drempapis drempapis added auto-backport Automatically create backport pull requests when merged v9.1.0 labels Aug 11, 2025
@drempapis drempapis merged commit dcff4d3 into elastic:main Aug 11, 2025
33 checks passed
@drempapis drempapis mentioned this pull request Aug 11, 2025
Merged
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Aug 11, 2025

💚 Backport successful

Status Branch Result
✅ 9.1

drempapis added a commit to drempapis/elasticsearch that referenced this pull request Aug 11, 2025
@drempapis
update code and unmute test| (elastic#132648)
9d1af70
@smalyshev
Copy link
Copy Markdown
Contributor

smalyshev commented Aug 11, 2025

@drempapis 8.19 too?

@drempapis
Copy link
Copy Markdown
Contributor Author

drempapis commented Aug 11, 2025

@smalyshev This issue was initially reported but not muted in the branch version 8.19.

elasticsearchmachine pushed a commit that referenced this pull request Aug 12, 2025
@drempapis
update code and unmute test| (#132648) (#132679)
ff4c318
@drempapis drempapis mentioned this pull request Aug 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smalyshev smalyshev smalyshev approved these changes

@pawankartik-elastic pawankartik-elastic pawankartik-elastic approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.1.0 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] CCSDuelIT testTerminateAfter failing

4 participants

@drempapis @elasticsearchmachine @pawankartik-elastic @smalyshev