Merged
Conversation
Contributor
romulets
commented
Aug 7, 2025
...esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/date/DayName.java
Show resolved
Hide resolved
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
requested changes
Aug 7, 2025
Member
nik9000
left a comment
There was a problem hiding this comment.
Looks good to me. You need to make a change to the docs generation and rerun the test for it to slurp the docs change into the generated docs. But otherwise I think it's read.
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
Outdated
Show resolved
Hide resolved
...esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/date/DayName.java
Show resolved
Hide resolved
...esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/date/DayName.java
Show resolved
Hide resolved
Member
ready |
romulets
commented
Aug 8, 2025
...esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/date/DayName.java
Show resolved
Hide resolved
...esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/date/DayName.java
Show resolved
Hide resolved
nik9000
approved these changes
Aug 8, 2025
alex-spies
added a commit
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #98545
Introduces
DAY_NAMEfunction, similar to MySQL behaviour.Given a
dateordate_nanosreturn the weekday name for the specified day based on the configured Locale