Remove awaits for closed issues#132306
Merged
smalyshev merged 19 commits intoelastic:mainfrom Aug 14, 2025
Merged
Conversation
9dfe06b to
a01521c
Compare
Contributor
Author
7e1d6dc to
b2c235d
Compare
9d6d207 to
36b8b20
Compare
benwtrent
reviewed
Aug 13, 2025
muted-tests.yml
Outdated
Comment on lines
+540
to
+541
| method: test {csv-spec:mv_percentile.FromIndexPercentile} | ||
| issue: https://github.com/elastic/elasticsearch/issues/132846 |
Member
There was a problem hiding this comment.
seems weird, shouldn't there be another class line?
Contributor
Author
There was a problem hiding this comment.
Yes seems like merge conflict resolved badly, will fix. Thanks!
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Fill in some issues
This was referenced Aug 13, 2025
More issues
This was referenced Aug 13, 2025
benwtrent
approved these changes
Aug 14, 2025
Member
benwtrent
left a comment
There was a problem hiding this comment.
👍 thank you for addressing this debt!
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Aug 15, 2025
* Remove awaits for closed issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
@AwaitFixtags for issues that are closed. If the test is broken, this should be surfaced, there's no point to keep it around muted since the issue is not going to be looked on when it's closed.