Fix DenseVectorFieldIndexTypeUpdateIT test#132176
Merged
carlosdelest merged 7 commits intoelastic:mainfrom Jul 31, 2025
Merged
Conversation
carlosdelest
commented
Jul 30, 2025
| assertNoFailuresAndResponse(client().prepareSearch(INDEX_NAME).setSize(expectedDocs + 10), response -> { | ||
|
|
||
| // Count query | ||
| assertNoFailuresAndResponse(client().prepareSearch(INDEX_NAME).setSize(0).setTrackTotalHits(true).setSize(expectedDocs), response -> { |
Member
Author
There was a problem hiding this comment.
Added a count query as well as a knn query to ensure results are consistent
| private void indexDoc(int id) throws ExecutionException, InterruptedException { | ||
| Float[] vector = randomArray(dimensions, dimensions, Float[]::new, () -> randomFloatBetween(-1, 1, true)); | ||
| IndexRequest req = prepareIndex(INDEX_NAME).setSource(VECTOR_FIELD, vector).setId(Integer.toString(id)).request(); | ||
| client().index(req); |
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
john-wagster
approved these changes
Jul 30, 2025
Contributor
john-wagster
left a comment
There was a problem hiding this comment.
lgtm insane number of issues created ha
…r-update-tests # Conflicts: # muted-tests.yml
…ate-tests' into tests/fix-dense-vector-update-tests # Conflicts: # muted-tests.yml
This was referenced Jul 31, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Jul 31, 2025
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs indexation didn't wait for the index request to return, which caused doc count to fail in some instances.
Closes quite a few issues, as this is a parameterized test that checks all combinations of index upgrades.
Closes #132165
Closes #132164
Closes #132152
Closes #132151
Closes #132150
Closes #132149
Closes #132141
Closes #132140
Closes #132134
Closes #132133
Closes #132132
Closes #132130
Closes #132127
Closes #132126
Closes #132125
Closes #132124
Closes #132123
Closes #132122
Closes #132121
Closes #132120
Closes #132119
Closes #132117
Closes #132116
Closes #132115
Closes #132113
Closes #132112
Closes #132234
Closes #132228
Closes #132222
Closes #132221
Closes #132220
Closes #132219
Closes #132214
Closes #132213
Closes #132211
Closes #132189
Closes #132188