Merged
Conversation
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @jan-elastic, I've created a changelog YAML for you. |
0faee91 to
b308397
Compare
ddf2f1f to
5ed9dfa
Compare
Collaborator
|
Hi @jan-elastic, I've created a changelog YAML for you. |
ivancea
reviewed
Jul 15, 2025
.../src/test/java/org/elasticsearch/compute/aggregation/blockhash/CategorizeBlockHashTests.java
Show resolved
Hide resolved
...va/org/elasticsearch/compute/aggregation/blockhash/CategorizePackedValuesBlockHashTests.java
Outdated
Show resolved
Hide resolved
.../main/java/org/elasticsearch/xpack/ml/aggs/categorization/SerializableTokenListCategory.java
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
Show resolved
Hide resolved
...esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/Categorize.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| return new CategorizeDef( | ||
| (String) optionsMap.get("analyzer"), |
Contributor
There was a problem hiding this comment.
Can we validate the analyzer here?
Contributor
Author
There was a problem hiding this comment.
Not that I know of. You'd need the AnalysisRegistry here.
During execution, that comes via the EsPhysicalOperationProviders from the SearchService. I don't see how to obtain something similar at this stage.
Contributor
There was a problem hiding this comment.
Ok! As it's checked now at planning time, no problem then
|
@jan-elastic FYI there's no v8.20.0 as of now. I removed your label |
Contributor
Author
|
@ghudgins does that mean we're not backporting new functionality anymore? Just bugfixes to 8.19.x? |
a154ede to
5300744
Compare
Contributor
Author
|
@ivancea Thanks for the thorough review. Fixed all you comments. PTAL |
bpintea
approved these changes
Jul 16, 2025
...in/java/org/elasticsearch/compute/aggregation/blockhash/CategorizePackedValuesBlockHash.java
Show resolved
Hide resolved
...esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/Categorize.java
Outdated
Show resolved
Hide resolved
...esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/Categorize.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
Show resolved
Hide resolved
5300744 to
6248657
Compare
Contributor
Author
|
@bpintea Thanks for your review. Fixed all your comments |
ivancea
approved these changes
Jul 16, 2025
6248657 to
db90b33
Compare
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 17, 2025
* ES|QL categorize options * refactor options * fix serialization * polish * add verfications * better test coverage + polish code * better test coverage + polish code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The categorizate text agg has some configuration options. ES|QL categorize does not.
This PR adds them with syntax comparable to options of the ES|QL
matchfunction.The exposed options are:
Furthermore, the options functionality of
matchis refactored to make it reusable.