Wait for state publication in SLMFileSettingsIT.testSettingsApplied#130869
Wait for state publication in SLMFileSettingsIT.testSettingsApplied#130869nielsbauman merged 3 commits intoelastic:mainfrom
SLMFileSettingsIT.testSettingsApplied#130869Conversation
Since the cluster state API no longer runs on the master node, we need to wait for the cluster state publication to have finished before retrieving the cluster state. Fixes elastic#130853
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
left a comment
There was a problem hiding this comment.
LGTM. I'm not very familiar with this test though. Do we need the same awaitMasterNode() call in assertClusterStateNotSaved()? And is the call to awaitMasterNode() for a single node just before calling assertClusterStateSaveOK() now redundant?
|
Thanks for the review, @masseyke!
Good question, I hadn't considered it yet. Looking at it now, we don't need
Another great question! You're right; I've removed that call. Thanks a lot for the review! |
…elastic#130869) Since the cluster state API no longer runs on the master node, we need to wait for the cluster state publication to have finished before retrieving the cluster state. Fixes elastic#130853
…elastic#130869) Since the cluster state API no longer runs on the master node, we need to wait for the cluster state publication to have finished before retrieving the cluster state. Fixes elastic#130853
…37669) This is pretty much a copy of elastic#130869. Since the cluster state API no longer runs on the master node, we need to wait for the cluster state publication to have finished before retrieving the cluster state. Fixes elastic#137258 (cherry picked from commit bc5bc54) # Conflicts: # muted-tests.yml
…37669) This is pretty much a copy of elastic#130869. Since the cluster state API no longer runs on the master node, we need to wait for the cluster state publication to have finished before retrieving the cluster state. Fixes elastic#137258
…37669) This is pretty much a copy of elastic#130869. Since the cluster state API no longer runs on the master node, we need to wait for the cluster state publication to have finished before retrieving the cluster state. Fixes elastic#137258
Since the cluster state API no longer runs on the master node, we need to wait for the cluster state publication to have finished before retrieving the cluster state.
Fixes #130853