Skip to content

Check file entitlements on the Lucene FilterFileSystem in tests#130825

Merged
elasticsearchmachine merged 15 commits intoelastic:mainfrom
mosche:entitlements/fix-default-fs-predicate-for-tests
Jul 12, 2025
Merged

Check file entitlements on the Lucene FilterFileSystem in tests#130825
elasticsearchmachine merged 15 commits intoelastic:mainfrom
mosche:entitlements/fix-default-fs-predicate-for-tests

Conversation

@mosche
Copy link
Copy Markdown
Contributor

@mosche mosche commented Jul 8, 2025 •
edited
Loading

So far most file entitlement checks have been trivially allowed due to usage of the Lucene FilterFileSystem.
This makes sure we properly check for that file system in tests.

Fixes #127686
Fixes #127193
Fixes #127192
Fixes #127190

Relates to ES-12210
Relates to ES-12242

@mosche mosche requested a review from a team as a code owner July 8, 2025 14:24
@mosche mosche added :Core/Infra/Entitlements Entitlements infrastructure test-windows Trigger CI checks on Windows test-fips Trigger CI checks for FIPS auto-backport Automatically create backport pull requests when merged v9.2.0 v9.1.1 v8.19.1 labels Jul 8, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jul 8, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Jul 8, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

@mosche mosche added the >test Issues or PRs that are addressing/adding tests label Jul 8, 2025
ldematte
ldematte approved these changes Jul 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@mosche mosche added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 8, 2025
@ldematte
Copy link
Copy Markdown
Contributor

ldematte commented Jul 12, 2025

Serverless test failures are unrelated, trying to re-run them.

@elasticsearchmachine elasticsearchmachine merged commit 3f0b14b into elastic:main Jul 12, 2025
45 checks passed
@mosche mosche deleted the entitlements/fix-default-fs-predicate-for-tests branch July 12, 2025 10:35
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Jul 12, 2025

💔 Backport failed

Status Branch Result
❌ 9.1 Commit could not be cherrypicked due to conflicts
❌ 8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 130825

@mosche mosche mentioned this pull request Jul 14, 2025
Merged
mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 14, 2025
@mosche
Check file entitlements on the Lucene FilterFileSystem in tests (elas…
8efb1ad 
…tic#130825)

So far most file entitlement checks have been trivially allowed due to
usage of the Lucene FilterFileSystem. This makes sure we properly check
for that file system in tests.

Fixes elastic#127686 Fixes elastic#127193 Fixes elastic#127192 Fixes elastic#127190

Relates to ES-12210 Relates to ES-12242

(cherry picked from commit 3f0b14b)

# Conflicts:
#	muted-tests.yml
@mosche mosche mentioned this pull request Jul 14, 2025
Merged
@mosche
Copy link
Copy Markdown
Contributor Author

mosche commented Jul 14, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1
✅ 8.19

Questions ?

Please refer to the Backport tool documentation

mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 14, 2025
@mosche
Check file entitlements on the Lucene FilterFileSystem in tests (elas…
bcfb352 
…tic#130825)

So far most file entitlement checks have been trivially allowed due to
usage of the Lucene FilterFileSystem. This makes sure we properly check
for that file system in tests.

Fixes elastic#127686 Fixes elastic#127193 Fixes elastic#127192 Fixes elastic#127190

Relates to ES-12210 Relates to ES-12242

(cherry picked from commit 3f0b14b)

# Conflicts:
#	muted-tests.yml
szybia added a commit to szybia/elasticsearch that referenced this pull request Jul 14, 2025
@szybia
Merge remote-tracking branch 'upstream/main' into index-pipeline-trac…
e28b781 
…king

* upstream/main: (33 commits)
  Allow both WithEntitlementsOnTestCode and EntitledTestPackages together (elastic#130826)
  Move streams status actions to cluster:monitor group (elastic#131015)
  Update JDK base image for OIDC fixture (elastic#131176)
  Mute org.elasticsearch.xpack.esql.ccq.MultiClustersIT testLookupJoinAliases elastic#131166
  Mute org.elasticsearch.index.engine.ThreadPoolMergeExecutorServiceDiskSpaceTests testEnqueuedMergeTasksAreUnblockedWhenEstimatedMergeSizeChanges elastic#131165
  Mute org.elasticsearch.xpack.esql.ccq.MultiClustersIT testNotLikeListKeyword elastic#131155
  Mute org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT test elastic#131154
  Check file entitlements on the Lucene FilterFileSystem in tests (elastic#130825)
  Mute org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT test {lookup-join.MvJoinKeyOnFromAfterStats ASYNC} elastic#131148
  Move FrequencyCappedAction to common package (elastic#131060)
  Mute org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryStopIT testStopQueryLocal elastic#121672
  Remove nesting from multi allocation decision (elastic#130844)
  Disable async search rest tests in release builds (elastic#131132)
  Fix testStopQueryLocal (elastic#131130)
  Fixes based on resharding disruption tests (elastic#130870)
  Remove inactive logger (elastic#131121)
  Add wait for remote start for the test (elastic#131124)
  Add existing shards allocator settings to failure store allowed list. (elastic#131056)
  Don't allow field caps to use semantic queries as index filters (elastic#131111)
  issue should be already fixed by elastic#121466 (elastic#130860)
  ...
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@mosche
Check file entitlements on the Lucene FilterFileSystem in tests (#130825
c237cd2 
) (#131184)

So far most file entitlement checks have been trivially allowed due to
usage of the Lucene FilterFileSystem. This makes sure we properly check
for that file system in tests.

Fixes #127686 Fixes #127193 Fixes #127192 Fixes #127190

Relates to ES-12210 Relates to ES-12242

(cherry picked from commit 3f0b14b)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Jul 14, 2025
@mosche
Check file entitlements on the Lucene FilterFileSystem in tests (#130825
0c7305b 
) (#131185)

So far most file entitlement checks have been trivially allowed due to
usage of the Lucene FilterFileSystem. This makes sure we properly check
for that file system in tests.

Fixes #127686 Fixes #127193 Fixes #127192 Fixes #127190

Relates to ES-12210 Relates to ES-12242

(cherry picked from commit 3f0b14b)

# Conflicts:
#	muted-tests.yml
@ldematte ldematte mentioned this pull request Jul 16, 2025
Closed
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@mosche @mridula-s109
Check file entitlements on the Lucene FilterFileSystem in tests (elas…
00e8abc 
…tic#130825)

So far most file entitlement checks have been trivially allowed due to
usage of the Lucene FilterFileSystem. This makes sure we properly check
for that file system in tests.

Fixes elastic#127686 Fixes elastic#127193 Fixes elastic#127192 Fixes elastic#127190

Relates to ES-12210 Relates to ES-12242
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
@mosche @mridula-s109
Check file entitlements on the Lucene FilterFileSystem in tests (elas…
39f0054 
…tic#130825)

So far most file entitlement checks have been trivially allowed due to
usage of the Lucene FilterFileSystem. This makes sure we properly check
for that file system in tests.

Fixes elastic#127686 Fixes elastic#127193 Fixes elastic#127192 Fixes elastic#127190

Relates to ES-12210 Relates to ES-12242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldematte ldematte ldematte approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests test-fips Trigger CI checks for FIPS test-windows Trigger CI checks on Windows v8.19.1 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

3 participants

@mosche @elasticsearchmachine @ldematte