Merged
Conversation
Contributor
|
🔍 Preview links for changed docs: 🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
leemthompo
reviewed
Jun 30, 2025
docs/reference/query-languages/esql/_snippets/lists/processing-commands.md
Outdated
Show resolved
Hide resolved
leemthompo
reviewed
Jun 30, 2025
leemthompo
reviewed
Jun 30, 2025
Member
leemthompo
left a comment
There was a problem hiding this comment.
This looks good! I made a couple of comments earlier outside of a proper review, one of which should fix the broken build.
I have a few minor wording suggestions here, but otherwise I have 2 general remarks:
- Maybe we could have a bit more "Why Use FORK?" information at the outset.
- Explain when to use FORK (applying different processing logic to the same dataset)
- Advantages over multiple separate queries or complex CASE statements
- Common use cases
- Add More Examples
- Include comparison examples showing FORK vs alternatives
But that might be out of scope for initial release, so it could just be future food for thought :)
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
…-commands.md Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
leemthompo
approved these changes
Jun 30, 2025
Member
leemthompo
left a comment
There was a problem hiding this comment.
I have just a few more suggestions to basically group related info (branch id, column handling, row ordering) in a more readable fashion. I'd still like to see a couple more illustrative examples but understand this might be good enough for now. :)
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
23 tasks
leemthompo
reviewed
Jun 30, 2025
docs/reference/query-languages/esql/_snippets/commands/layout/fork.md
Outdated
Show resolved
Hide resolved
…fork.md Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Collaborator
💚 Backport successful
|
ioanatia
added a commit
to ioanatia/elasticsearch
that referenced
this pull request
Jun 30, 2025
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 30, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#121950
Does what is says.
Now that FORK is out of snapshot and in tech preview, we need to document the feature.