Move multicast discovery to a plugin#13027
Conversation
Multicast has known issues (see elastic#12999 and elastic#12993). This change moves multicast into a plugin, and deprecates it in the docs. It also allows for plugging in multiple zen ping implementations. closes elastic#13019
|
The plugin works, I installed it and set the boolean and things joined over the network. |
There was a problem hiding this comment.
You can also remove the second comment.
|
I pushed new commits. mvn verify passes. |
|
I also ran verify with -Des.node.mode=network |
|
me too. +1 |
Move multicast discovery to a plugin
|
Missing change in https://github.com/elastic/elasticsearch/blob/master/core/src/main/java/org/elasticsearch/plugins/PluginManager.java and in plugin manager tests. |
|
LGTM2, apart from what @dadoonet said (which I wouldn't have come up with my self ... ) |
|
Yeah we need to find a way to automatically fail when we omit such a change. |
|
@rjernst Also the documentation build is failing. Could you check? |
|
@rjernst I think this should this be backported to 2.0 branch? |
|
Yes, I wanted to give CI a little time to chew. I'll backport now. |
|
@rjernst Could you also add |
done on master and 2.0 |
|
@rjernst Please could you add this to the migration docs as well |
Multicast has known issues (see #12999 and #12993). This change moves
multicast into a plugin, and deprecates it in the docs. It also allows
for plugging in multiple zen ping implementations.
I think we should also state in the docs this is deprecated, but I didn't know how to word that or how to mark something as deprecated in asciidoc.
closes #13019