[Test] Fix FileSettingsRoleMappingsRestartIT#129618
Merged
slobodanadamovic merged 2 commits intoelastic:mainfrom Jun 24, 2025
Merged
[Test] Fix FileSettingsRoleMappingsRestartIT#129618slobodanadamovic merged 2 commits intoelastic:mainfrom
slobodanadamovic merged 2 commits intoelastic:mainfrom
Conversation
The elastic#27318 changed the behaviour of `client()` to not start a node if there is none found in the cluster. Which also changed the `getMasterName()` behaviour to simply fail if there are no nodes instead of starting one. This is why the `getMasterName()` is failing now. There were no nodes started because the test scope is set to manually manage master nodes (`autoManageMasterNodes = false`) without data nodes (`numDataNodes = 0`). The fix is to actually start the master node instead of attempting to get the master node name from an empty cluster and depend on a side effect to actually boostrap a node. Resolves elastic#120964 Resolves elastic#120923
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
ankit--sethi
approved these changes
Jun 23, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Jun 24, 2025
The elastic#127318 changed the behaviour of `client()` to not start a node if there is none found in the cluster. Which also changed the `getMasterName()` behaviour to simply fail if there are no nodes instead of starting one. This is why the `getMasterName()` is failing now. There were no nodes started because the test scope is set to manually manage master nodes (`autoManageMasterNodes = false`) without data nodes (`numDataNodes = 0`). The fix is to actually start the master node instead of attempting to get the master node name from an empty cluster and depend on a side effect to actually boostrap a node. Additionally it awaits for the master node to process all cluster state events before proceeding, which should hopefully solve the original cause of failures. Resolves elastic#120964 Resolves elastic#120923 (cherry picked from commit ee6d64a) # Conflicts: # muted-tests.yml
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
The elastic#127318 changed the behaviour of `client()` to not start a node if there is none found in the cluster. Which also changed the `getMasterName()` behaviour to simply fail if there are no nodes instead of starting one. This is why the `getMasterName()` is failing now. There were no nodes started because the test scope is set to manually manage master nodes (`autoManageMasterNodes = false`) without data nodes (`numDataNodes = 0`). The fix is to actually start the master node instead of attempting to get the master node name from an empty cluster and depend on a side effect to actually boostrap a node. Additionally it awaits for the master node to process all cluster state events before proceeding, which should hopefully solve the original cause of failures. Resolves elastic#120964 Resolves elastic#120923
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #127318 changed the behaviour of
client()to not start a node if there is none found in the cluster. Which also changed thegetMasterName()behaviour to simply fail if there are no nodes instead of starting one.This is why the
getMasterName()is failing now. There were no nodes started because the test scope is set to manually manage master nodes (autoManageMasterNodes = false) without data nodes (numDataNodes = 0).The fix is to actually start the master node instead of attempting to get the master node name from an empty cluster and depend on a side effect to actually boostrap a node.
Additionally it awaits for the master node to process all cluster state events before proceeding, which should hopefully solve the original cause of failures.
Resolves #120964
Resolves #120923