Fix fieldName in FieldAttribute#129427
Merged
dnhatn merged 1 commit intoelastic:mainfrom Jun 13, 2025
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Jun 13, 2025
Contributor
alex-spies
left a comment
There was a problem hiding this comment.
Ah! Thanks a ton for finding this. Great!
fang-xing-esql
approved these changes
Jun 13, 2025
Member
fang-xing-esql
left a comment
There was a problem hiding this comment.
Good catch, thank you @dnhatn !
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jun 13, 2025
I believe we missed the if/else here in elastic#128910; without it, we won't maintain backward compatibility with pre-8.15. This is no longer necessary in main since it doesn't interact with pre-8.15 nodes. I'll open a follow-up to remove it from main, but it's required in 8.19 and 8.18 because mixed cluster tests are failing without it. Relates elastic#128910 Closes elastic#129412 Closes elastic#129411 Closes elastic#129375 Closes elastic#129374 Closes elastic#129373 Closes elastic#129340 Closes elastic#129339 Closes elastic#129304 Closes elastic#129303 Closes elastic#129410 Closes elastic#129409 Closes elastic#129408 Closes elastic#129407 Closes elastic#129379 Closes elastic#129378 Closes elastic#129377 Closes elastic#129376 Closes elastic#129307 Closes elastic#129306 Closes elastic#129305
This was referenced Jun 13, 2025
Collaborator
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jun 13, 2025
I believe we missed the if/else here in elastic#128910; without it, we won't maintain backward compatibility with pre-8.15. This is no longer necessary in main since it doesn't interact with pre-8.15 nodes. I'll open a follow-up to remove it from main, but it's required in 8.19 and 8.18 because mixed cluster tests are failing without it. Relates elastic#128910 Closes elastic#129412 Closes elastic#129411 Closes elastic#129375 Closes elastic#129374 Closes elastic#129373 Closes elastic#129340 Closes elastic#129339 Closes elastic#129304 Closes elastic#129303 Closes elastic#129410 Closes elastic#129409 Closes elastic#129408 Closes elastic#129407 Closes elastic#129379 Closes elastic#129378 Closes elastic#129377 Closes elastic#129376 Closes elastic#129307 Closes elastic#129306 Closes elastic#129305
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jun 13, 2025
I believe we missed the if/else here in elastic#128910; without it, we won't maintain backward compatibility with pre-8.15. This is no longer necessary in main since it doesn't interact with pre-8.15 nodes. I'll open a follow-up to remove it from main, but it's required in 8.19 and 8.18 because mixed cluster tests are failing without it. Relates elastic#128910 Closes elastic#129412 Closes elastic#129411 Closes elastic#129375 Closes elastic#129374 Closes elastic#129373 Closes elastic#129340 Closes elastic#129339 Closes elastic#129304 Closes elastic#129303 Closes elastic#129410 Closes elastic#129409 Closes elastic#129408 Closes elastic#129407 Closes elastic#129379 Closes elastic#129378 Closes elastic#129377 Closes elastic#129376 Closes elastic#129307 Closes elastic#129306 Closes elastic#129305
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 13, 2025
I believe we missed the if/else here in #128910; without it, we won't maintain backward compatibility with pre-8.15. This is no longer necessary in main since it doesn't interact with pre-8.15 nodes. I'll open a follow-up to remove it from main, but it's required in 8.19 and 8.18 because mixed cluster tests are failing without it. Relates #128910 Closes #129412 Closes #129411 Closes #129375 Closes #129374 Closes #129373 Closes #129340 Closes #129339 Closes #129304 Closes #129303 Closes #129410 Closes #129409 Closes #129408 Closes #129407 Closes #129379 Closes #129378 Closes #129377 Closes #129376 Closes #129307 Closes #129306 Closes #129305
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 13, 2025
I believe we missed the if/else here in #128910; without it, we won't maintain backward compatibility with pre-8.15. This is no longer necessary in main since it doesn't interact with pre-8.15 nodes. I'll open a follow-up to remove it from main, but it's required in 8.19 and 8.18 because mixed cluster tests are failing without it. Relates #128910 Closes #129412 Closes #129411 Closes #129375 Closes #129374 Closes #129373 Closes #129340 Closes #129339 Closes #129304 Closes #129303 Closes #129410 Closes #129409 Closes #129408 Closes #129407 Closes #129379 Closes #129378 Closes #129377 Closes #129376 Closes #129307 Closes #129306 Closes #129305
dnhatn
added a commit
that referenced
this pull request
Jun 13, 2025
I believe we missed the if/else here in #128910; without it, we won't maintain backward compatibility with pre-8.15. This is no longer necessary in main since it doesn't interact with pre-8.15 nodes. I'll open a follow-up to remove it from main, but it's required in 8.19 and 8.18 because mixed cluster tests are failing without it. Relates #128910 Closes #129412 Closes #129411 Closes #129375 Closes #129374 Closes #129373 Closes #129340 Closes #129339 Closes #129304 Closes #129303 Closes #129410 Closes #129409 Closes #129408 Closes #129407 Closes #129379 Closes #129378 Closes #129377 Closes #129376 Closes #129307 Closes #129306 Closes #129305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe we missed the if/else here in #128910; without it, we won't maintain backward compatibility with pre-8.15. This is no longer necessary in main since it doesn't interact with pre-8.15 nodes. I'll open a follow-up to remove it from main, but it's required in 8.19 and 8.18 because mixed cluster tests are failing without it.
Relates #128910
Closes #129412
Closes #129411
Closes #129375
Closes #129374
Closes #129373
Closes #129340
Closes #129339
Closes #129304
Closes #129303
Closes #129410
Closes #129409
Closes #129408
Closes #129407
Closes #129379
Closes #129378
Closes #129377
Closes #129376
Closes #129307
Closes #129306
Closes #129305