[ML] Write Chat Completion JSON#128592
Merged
prwhelan merged 2 commits intoelastic:mainfrom May 29, 2025
Merged
Conversation
Most providers write the UnifiedCompletionRequest JSON as we received it, with some exception: - the modelId can be null and/or overwritten from various locations - `max_completion_tokens` repalced `max_tokens`, but some providers still use the deprecated field name We will handle the variations using Params, otherwise all of the XContent building code has moved into UnifiedCompletionRequest so it can be reused across providers.
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
approved these changes
May 29, 2025
Contributor
jonathan-buttner
left a comment
There was a problem hiding this comment.
Thanks for refactoring Pat!
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
6 tasks
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
May 29, 2025
Most providers write the UnifiedCompletionRequest JSON as we received it, with some exception: - the modelId can be null and/or overwritten from various locations - `max_completion_tokens` repalced `max_tokens`, but some providers still use the deprecated field name We will handle the variations using Params, otherwise all of the XContent building code has moved into UnifiedCompletionRequest so it can be reused across providers.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 30, 2025
Most providers write the UnifiedCompletionRequest JSON as we received it, with some exception: - the modelId can be null and/or overwritten from various locations - `max_completion_tokens` repalced `max_tokens`, but some providers still use the deprecated field name We will handle the variations using Params, otherwise all of the XContent building code has moved into UnifiedCompletionRequest so it can be reused across providers.
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
Most providers write the UnifiedCompletionRequest JSON as we received it, with some exception: - the modelId can be null and/or overwritten from various locations - `max_completion_tokens` repalced `max_tokens`, but some providers still use the deprecated field name We will handle the variations using Params, otherwise all of the XContent building code has moved into UnifiedCompletionRequest so it can be reused across providers.
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
Most providers write the UnifiedCompletionRequest JSON as we received it, with some exception: - the modelId can be null and/or overwritten from various locations - `max_completion_tokens` repalced `max_tokens`, but some providers still use the deprecated field name We will handle the variations using Params, otherwise all of the XContent building code has moved into UnifiedCompletionRequest so it can be reused across providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most providers write the UnifiedCompletionRequest JSON as we received it, with some exception:
max_completion_tokensrepalcedmax_tokens, but some providers still use the deprecated field name We will handle the variations using Params, otherwise all of the XContent building code has moved into UnifiedCompletionRequest so it can be reused across providers.