Brings Lucene query assertions back to QB test.#12810
Merged
MaineC merged 1 commit intoelastic:feature/query-refactoringfrom Aug 20, 2015
Merged
Brings Lucene query assertions back to QB test.#12810MaineC merged 1 commit intoelastic:feature/query-refactoringfrom
MaineC merged 1 commit intoelastic:feature/query-refactoringfrom
Conversation
Contributor
|
I am conflicted on whether the |
Member
There was a problem hiding this comment.
From first glance to me its not clear why all these assertions are the same. When is this not the case and might it be easier to just test those cases? Not sure because I don't know how the resolution works though.
50c9b81 to
627213a
Compare
This brings the Lucene query assertions back to the querybuilder test that were removed in the ancient past when we tested Lucene queries through their inherent equals method. As we no longer do that it makes sense to do at least coarse sanity checking on the generated Lucene query. More such checks are being added as part of this commit. Relates to elastic#10217
627213a to
7dcf0da
Compare
Author
|
@cbuescher Thanks for your comment - I changed the if in question slightly, feel free to take another look. |
Member
|
@MaineC thanks, now I see the different cases much clearer. LGTM |
MaineC
pushed a commit
that referenced
this pull request
Aug 20, 2015
Brings Lucene query assertions to QB test. Theser assertions were originally added as part of the SimpleQueryStringQueryBuilder refactoring but removed later as there were more extensive tests in place already. This commit brings them back in as the other tests have been removed. This relates to #10217 and #11274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the Lucene query assertions back to the querybuilder test that were
removed in the ancient past when we tested Lucene queries through their
inherent equals method. As we no longer do that it makes sense to do at least
coarse sanity checking on the generated Lucene query. More such checks are
being added as part of this commit.
Note: This goes against the feature/query-refactoring feature branch.
Relates to #10217