Merged
Conversation
|
💚 CLA has been signed |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Member
luigidellaquila
left a comment
There was a problem hiding this comment.
Thanks @shmuelhanoch
I'm adding here some notes about what we discussed off-line
x-pack/plugin/esql/qa/testFixtures/src/main/resources/floats.csv-spec
Outdated
Show resolved
Hide resolved
...n/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/math/Round.java
Show resolved
Hide resolved
...n/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/math/Scalb.java
Show resolved
Hide resolved
x-pack/plugin/esql/qa/testFixtures/src/main/resources/floats.csv-spec
Outdated
Show resolved
Hide resolved
...n/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/math/Scalb.java
Outdated
Show resolved
Hide resolved
Member
|
Please also add some tests for pathological cases, like very large numbers and null values. |
d195b7a to
f0509dc
Compare
1b913c2 to
0ba09bf
Compare
5b8b482 to
e9a5411
Compare
e9a5411 to
fe3b312
Compare
fe3b312 to
65d1212
Compare
741461d to
96896de
Compare
Member
luigidellaquila
left a comment
There was a problem hiding this comment.
Thanks @shmuelhanoch
One more thing about docs: please add the function also to
https://github.com/elastic/elasticsearch/blob/main/docs/reference/query-languages/esql/_snippets/lists/math-functions.md
and
https://github.com/elastic/elasticsearch/blob/main/docs/reference/query-languages/esql/functions-operators/math-functions.md
@craigtaverner we need both with the new docs, right...?
96896de to
5f64606
Compare
5f64606 to
f1f939a
Compare
Member
luigidellaquila
left a comment
There was a problem hiding this comment.
Thanks @shmuelhanoch, I think we are almost there. Just one small thing about a csv test
x-pack/plugin/esql/qa/testFixtures/src/main/resources/floats.csv-spec
Outdated
Show resolved
Hide resolved
f1f939a to
e68b48e
Compare
e68b48e to
26448d4
Compare
|
Hi @luigidellaquila @shmuelhanoch can this be backported to 8.19.0? |
Member
|
@tylerperk I'll take care of it |
luigidellaquila
pushed a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Jun 3, 2025
Co-authored-by: Shmuel Hanoch <shmuel.hanoch@elastic.co>
Member
|
Manual backport here #128815 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 3, 2025
Member
|
@shmuelhanoch @luigidellaquila don't forget that nowadays we need to add applies_to tags for all docs changes (example), because we don't publish on separate minor branches. Can you confirm:
I'll open PR to fix :-) |
leemthompo
added a commit
to leemthompo/elasticsearch
that referenced
this pull request
Jul 24, 2025
leemthompo
added a commit
that referenced
this pull request
Jul 28, 2025
leemthompo
added a commit
to leemthompo/elasticsearch
that referenced
this pull request
Jul 28, 2025
* Add applies to to ScalB function in elastic#127696 * Add applies_to to categorize, follow up to elastic#129398 * Add version info, following elastic#127629 * SAMPLE is new + GA in 9.1 elastic#127629 * add applies to for 9.2 option (cherry picked from commit 5d565b5) # Conflicts: # docs/reference/query-languages/esql/_snippets/functions/parameters/categorize.md # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/Categorize.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 28, 2025
* Add applies to to ScalB function in #127696 * Add applies_to to categorize, follow up to #129398 * Add version info, following #127629 * SAMPLE is new + GA in 9.1 #127629 * add applies to for 9.2 option (cherry picked from commit 5d565b5) # Conflicts: # docs/reference/query-languages/esql/_snippets/functions/parameters/categorize.md # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/grouping/Categorize.java
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Jul 28, 2025
* Add applies to to ScalB function in elastic#127696 * Add applies_to to categorize, follow up to elastic#129398 * Add version info, following elastic#127629 * SAMPLE is new + GA in 9.1 elastic#127629 * add applies to for 9.2 option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #98545.