Skip to content

Add complete attribute to .fleet-agents docs#127651

Merged
ebeahan merged 4 commits intoelastic:mainfrom
pkoutsovasilis:fix/fleet_agents_snapshot_mapping
Jun 9, 2025
Merged

Add complete attribute to .fleet-agents docs#127651
ebeahan merged 4 commits intoelastic:mainfrom
pkoutsovasilis:fix/fleet_agents_snapshot_mapping

Conversation

@pkoutsovasilis
Copy link
Copy Markdown
Contributor

@pkoutsovasilis pkoutsovasilis commented May 2, 2025

This PR adds complete attribute to .fleet-agents docs that was introduced by this PR

@pkoutsovasilis pkoutsovasilis added :Core/Infra/Plugins Plugin API and infrastructure auto-backport Automatically create backport pull requests when merged v8.18.1 v9.0.1 v9.1.0 labels May 2, 2025
@pkoutsovasilis pkoutsovasilis self-assigned this May 2, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 2, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label May 2, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @pkoutsovasilis, I've created a changelog YAML for you.

@jamie-wilson88 jamie-wilson88 changed the title Add snapshot attribute to .fleet-agents docs Add complete attribute to .fleet-agents docs May 2, 2025
@JVerwolf
Copy link
Copy Markdown
Contributor

JVerwolf commented Jun 3, 2025

@juliaElastic / @nchaulet mind taking a look? Adding you both I see you've edited this file in the past, and I see that you're on the fleet team. I'll remove core/infra as this isn't in our purview. Thank you!

@JVerwolf JVerwolf removed the :Core/Infra/Plugins Plugin API and infrastructure label Jun 3, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:Core/Infra Meta label for core/infra team label Jun 3, 2025
@JVerwolf JVerwolf requested review from juliaElastic and nchaulet June 3, 2025 18:26
@ebeahan
Copy link
Copy Markdown
Member

ebeahan commented Jun 9, 2025

@elasticmachine test this please

@ebeahan ebeahan added v9.0.3 v8.18.3 :Core/Infra/Core Core issues without another label and removed v8.18.1 v9.0.1 labels Jun 9, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💚 Backport successful

Status Branch Result
9.0
8.18

pkoutsovasilis added a commit to pkoutsovasilis/elasticsearch that referenced this pull request Jun 9, 2025
* Add snapshot attribute to .fleet-agents docs

* Update docs/changelog/127651.yaml

* Fix changelog summary

---------

Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Jun 9, 2025
* Add snapshot attribute to .fleet-agents docs

* Update docs/changelog/127651.yaml

* Fix changelog summary

---------

Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Jun 9, 2025
* Add snapshot attribute to .fleet-agents docs

* Update docs/changelog/127651.yaml

* Fix changelog summary

---------

Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
valeriy42 pushed a commit to valeriy42/elasticsearch that referenced this pull request Jun 12, 2025
* Add snapshot attribute to .fleet-agents docs

* Update docs/changelog/127651.yaml

* Fix changelog summary

---------

Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
@lucabelluccini
Copy link
Copy Markdown
Contributor

Hello @pkoutsovasilis / @nchaulet / @juliaElastic
As a workaround, would we have any escape hatch to do a put mapping adding the complete field to the system index?
Would passing an header to the PUT .fleet-agents/_mapping bypass the system indices check? I'm asking as few users might not be able to upgrade and I was looking for a quick solution which doesn't involve upgrading.

@pkoutsovasilis
Copy link
Copy Markdown
Contributor Author

@lucabelluccini 👋 Apologies, I’m not sure how I missed this earlier.
From my testing, using PUT .fleet-agents/_mapping isn’t a viable workaround — Elasticsearch rejects the request with an error like:

{
  "error": {
    "root_cause": [
      {
        "type": "illegal_state_exception",
        "reason": "Cannot update mappings in [.fleet-agents-7]: system indices can only use mappings from their descriptors, but the mappings in the request [{\"properties\":{\"local_metadata\":{\"properties\":{\"panos\":{\"type\":\"keyword\"}}}}}] did not match those in the descriptor(s)"
      }
    ],
    "type": "illegal_state_exception",
    "reason": "Cannot update mappings in [.fleet-agents-7]: system indices can only use mappings from their descriptors, but the mappings in the request [{\"properties\":{\"local_metadata\":{\"properties\":{\"panos\":{\"type\":\"keyword\"}}}}}] did not match those in the descriptor(s)"
  },
  "status": 500
}

Unless there’s an undocumented escape hatch, I don’t believe system indices can be updated this way - they’re locked to the mappings defined in their descriptors.

@lucabelluccini
Copy link
Copy Markdown
Contributor

Hello @pkoutsovasilis - Thanks.
Yep that's what I thought... I think there's an header which we could pass, but I think in order to avoid any possible messing with system indices, we'll recommend to upgrade to a fixed version.

@lucabelluccini
Copy link
Copy Markdown
Contributor

Hello @pkoutsovasilis - we need to port this to 8.19.x branch and 8.17.x branches - I think this is mandatory given our new release cadence.

@pkoutsovasilis
Copy link
Copy Markdown
Contributor Author

@lucabelluccini thanks for catching that. I am gonna try to add the respective backport labels, but I don't have experience with this repo. I will also tag @ebeahan for awareness here

@pkoutsovasilis
Copy link
Copy Markdown
Contributor Author

and nothing happens after adding the labels... @michel-laterman @juliaElastic @nchaulet guys any ideas?

@ebeahan
Copy link
Copy Markdown
Member

ebeahan commented Aug 13, 2025

Not sure about the auto backporting. If needed, this is the guidance for manually triggering them:

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 127651

@ycombinator
Copy link
Copy Markdown
Contributor

I'm guessing the automated backporting only works on version labels added before the merge?

@rjernst
Copy link
Copy Markdown
Member

rjernst commented Aug 13, 2025

version labels added before the merge?

Yes that's right. You'll need to create the backport PRs manually now, unfortunately.

pkoutsovasilis added a commit to pkoutsovasilis/elasticsearch that referenced this pull request Aug 14, 2025
* Add snapshot attribute to .fleet-agents docs

* Update docs/changelog/127651.yaml

* Fix changelog summary

---------

Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
@pkoutsovasilis
Copy link
Copy Markdown
Contributor Author

@rjernst could you tell me, if you know, which gh label I should add in my backport PRs so the automated tool doesn't generate a new changelog for them? or maybe I should allow the automation to handle the changelog and I include only the index change there?

@rjernst
Copy link
Copy Markdown
Member

rjernst commented Aug 14, 2025

Backport PRs just need backport and auto-merge-without-approval. If you add eg >xxx labels I think that will generate a changelog.

elasticsearchmachine pushed a commit that referenced this pull request Aug 14, 2025
* Add snapshot attribute to .fleet-agents docs

* Update docs/changelog/127651.yaml

* Fix changelog summary

---------

Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
@pkoutsovasilis
Copy link
Copy Markdown
Contributor Author

@rjernst thanks for the guidance, one of the backports is already merged. But the other one fails on the CI #132903 for reasons unknown to me 🙁 Do you happen to know anybody that could help me with that?

elasticsearchmachine pushed a commit that referenced this pull request Aug 14, 2025
* Add snapshot attribute to .fleet-agents docs

* Update docs/changelog/127651.yaml

* Fix changelog summary

---------

Co-authored-by: Eric Beahan <eric.beahan@elastic.co>
@pkoutsovasilis
Copy link
Copy Markdown
Contributor Author

ok all backports are merged, after some retrying magic, thanks everybody for your help and guidance

szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 15, 2025
* upstream/8.19:
  [8.19] Fix MergeWithLowDiskSpaceIT testRelocationWhileForceMerging (elastic#132913)
  Allow the test to also accept partial, this seems to be normal (elastic#132614) (elastic#132949)
  Add `complete` attribute to .fleet-agents docs (elastic#127651) (elastic#132903)
  [8.19] docs: add 429 semantic_text troubleshooting (elastic#132747)
  Reduce logging levels for meter usage tests (elastic#131935) (elastic#131942)
  Add 8.19.2 Connectors release notes (elastic#132714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :Core/Infra/Core Core issues without another label external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Core/Infra Meta label for core/infra team Team:Fleet v8.17.11 v8.18.3 v8.19.3 v9.0.3 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants