Remove test usages of getDefaultBackingIndexName in DS and LogsDB tests#127384
Merged
nielsbauman merged 3 commits intoelastic:mainfrom Apr 29, 2025
Merged
Remove test usages of getDefaultBackingIndexName in DS and LogsDB tests#127384nielsbauman merged 3 commits intoelastic:mainfrom
getDefaultBackingIndexName in DS and LogsDB tests#127384nielsbauman merged 3 commits intoelastic:mainfrom
Conversation
…ests We replace usages of time sensitive `DataStream#getDefaultBackingIndexName` with the retrieval of the name via an API call. The problem with using the time sensitive method is that we can have test failures around midnight. Relates elastic#123376
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
14 tasks
nielsbauman
commented
Apr 25, 2025
Comment on lines
906
to
+909
| GetDataStreamAction.Response response = safeGet( | ||
| client().execute( | ||
| GetDataStreamAction.INSTANCE, | ||
| new GetDataStreamAction.Request(TEST_REQUEST_TIMEOUT, new String[] { dataStreamName }) | ||
| new GetDataStreamAction.Request(SAFE_AWAIT_TIMEOUT, new String[] { dataStreamName }) |
Contributor
Author
There was a problem hiding this comment.
Since safeGet(...) uses SAFE_AWAIT_TIMEOUT, I changed the timeout here to avoid confusion.
gmarouli
approved these changes
Apr 29, 2025
Contributor
gmarouli
left a comment
There was a problem hiding this comment.
LGTM! So much better :)
This was referenced Apr 29, 2025
Merged
Collaborator
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Apr 29, 2025
…ests (elastic#127384) We replace usages of time sensitive `DataStream#getDefaultBackingIndexName` with the retrieval of the name via an API call. The problem with using the time sensitive method is that we can have test failures around midnight. Relates elastic#123376
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Apr 30, 2025
…ests (elastic#127384) We replace usages of time sensitive `DataStream#getDefaultBackingIndexName` with the retrieval of the name via an API call. The problem with using the time sensitive method is that we can have test failures around midnight. Relates elastic#123376
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Apr 30, 2025
…ests (elastic#127384) We replace usages of time sensitive `DataStream#getDefaultBackingIndexName` with the retrieval of the name via an API call. The problem with using the time sensitive method is that we can have test failures around midnight. Relates elastic#123376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We replace usages of time sensitive
DataStream#getDefaultBackingIndexNamewith the retrieval of the name via an API call. The problem with using the time sensitive method is that we can have test failures around midnight.Relates #123376