Skip to content

test: check ES|QL SAMPLE capability before running analyzer/parser tests#127382

Merged
ChrisHegarty merged 4 commits intoelastic:mainfrom
ChrisHegarty:esql_release_test_fixes
Apr 25, 2025
Merged

test: check ES|QL SAMPLE capability before running analyzer/parser tests#127382
ChrisHegarty merged 4 commits intoelastic:mainfrom
ChrisHegarty:esql_release_test_fixes

Conversation

@ChrisHegarty
Copy link
Copy Markdown
Contributor

@ChrisHegarty ChrisHegarty commented Apr 25, 2025 •
edited
Loading

This commit resolves release test failures by checking the ES|QL SAMPLE capability before running the tests.

relates #125570

@ChrisHegarty ChrisHegarty added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) ES|QL-ui Impacts ES|QL UI labels Apr 25, 2025
@ChrisHegarty ChrisHegarty added the test-release Trigger CI checks against release build label Apr 25, 2025
@elasticsearchmachine elasticsearchmachine added v9.1.0 needs:triage Requires assignment of a team area label and removed Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Apr 25, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Apr 25, 2025

Pinging @elastic/kibana-esql (ES|QL-ui)

@ChrisHegarty ChrisHegarty added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 25, 2025
@elasticsearchmachine elasticsearchmachine removed the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 25, 2025
@ChrisHegarty ChrisHegarty added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL and removed ES|QL-ui Impacts ES|QL UI needs:triage Requires assignment of a team area label labels Apr 25, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Apr 25, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

bpintea
bpintea approved these changes Apr 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

ChrisHegarty commented Apr 25, 2025 •
edited
Loading

Basic ESQL usage output (telemetry) non-snapshot version is also failing. I don't understand why release test esql.features needs to be updated for a snapshot-only feature? Tho other snapshot features are listed here too? //cc @luigidellaquila

REPRODUCE WITH: ./gradlew ":x-pack:plugin:yamlRestTest" --tests "org.elasticsearch.xpack.test.rest.XPackRestIT.test {p0=esql/60_usage/Basic ESQL usage output (telemetry) non-snapshot version}" -Dtests.seed=3327970C418BA24F -Dbuild.snapshot=false -Dtests.jvm.argline="-Dbuild.snapshot=false" -Dlicense.key=x-pack/license-tools/src/test/resources/public.key -Dtests.locale=frr-Latn-DE -Dtests.timezone=Asia/Ashgabat -Druntime.java=24
XPackRestIT > test {p0=esql/60_usage/Basic ESQL usage output (telemetry) non-snapshot version} FAILED
    java.lang.AssertionError: Failure at [esql/60_usage:142]: field [esql.features] doesn't have length [25]
    Expected: <25>
         but: was <26>
        at __randomizedtesting.SeedInfo.seed([3327970C418BA24F:BB73A8D6EF77CFB7]:0)
        at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:522)
        at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:482)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
...

EDIT: seems that we return the telemetry for these features, just that they are 0.

ChrisHegarty
ChrisHegarty commented Apr 25, 2025
View reviewed changes
x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/esql/60_usage.yml
- match: {esql.functions.coalesce: $functions_coalesce}
- gt: {esql.functions.categorize: $functions_categorize}
- length: {esql.functions: 131} # check the "sister" test above for a likely update to the same esql.functions length check
- length: {esql.functions: 132} # check the "sister" test above for a likely update to the same esql.functions length check
Copy link
Copy Markdown
Contributor Author

@ChrisHegarty ChrisHegarty Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed for last_over_time, which bumped the sister test but not this one.

@ChrisHegarty ChrisHegarty merged commit 6dfb824 into elastic:main Apr 25, 2025
16 of 19 checks passed
@ChrisHegarty ChrisHegarty deleted the esql_release_test_fixes branch April 25, 2025 12:58
@drewdaemon
Copy link
Copy Markdown
Contributor

drewdaemon commented Apr 28, 2025

@ChrisHegarty thank you for the ping! What are you looking for from our side?

jan-elastic added a commit to jan-elastic/elasticsearch that referenced this pull request Jun 18, 2025
@jan-elastic
test: check ES|QL SAMPLE capability before running analyzer/parser te…
6825980 
…sts (elastic#127382)

This commit resolves release test failures by checking the ES|QL SAMPLE capability before running the tests.
jan-elastic added a commit to jan-elastic/elasticsearch that referenced this pull request Jun 18, 2025
@jan-elastic
test: check ES|QL SAMPLE capability before running analyzer/parser te…
d2f0492 
…sts (elastic#127382)

This commit resolves release test failures by checking the ES|QL SAMPLE capability before running the tests.
jan-elastic added a commit to jan-elastic/elasticsearch that referenced this pull request Jun 18, 2025
@jan-elastic
test: check ES|QL SAMPLE capability before running analyzer/parser te…
98f8b32 
…sts (elastic#127382)

This commit resolves release test failures by checking the ES|QL SAMPLE capability before running the tests.
jan-elastic added a commit to jan-elastic/elasticsearch that referenced this pull request Jun 19, 2025
@jan-elastic
test: check ES|QL SAMPLE capability before running analyzer/parser te…
a670b1b 
…sts (elastic#127382)

This commit resolves release test failures by checking the ES|QL SAMPLE capability before running the tests.
jan-elastic added a commit that referenced this pull request Jun 19, 2025
@jan-elastic
[8.19] Backport ES|QL sample processing command (#129617)
1d05947 
* ES|QL random sampling  (#125570)

* test: check ES|QL SAMPLE capability before running analyzer/parser tests (#127382)

This commit resolves release test failures by checking the ES|QL SAMPLE capability before running the tests.

* Fix ES|QL sample csv tests (#127838)

* Remove optional seed from ES|QL SAMPLE (#128887)

* Remove optional seed from ES|QL SAMPLE

* make it clear that seed is for testing

* rename ES|QL sample capability (#129193)

* remove stats correction from ES|QL sample (#129319)

* remove stats correction from ES|QL sample

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>

* Allow parameter for ES|QL SAMPLE (#129392)

* Allow parameter for ES|QL SAMPLE

* fix test to work around issue #120272

* remove unused postAnalysisVerification

* docs

* [CI] Auto commit changes from spotless

* fix usage

* Move ES|QL sample command from snapshot to tech preview (#129540)

* Move ES|QL sample command from snapshot to tech preview

* dev_sample -> sample

* fix test

* fix grammar

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idegtiarenko idegtiarenko idegtiarenko approved these changes

@bpintea bpintea bpintea approved these changes

@jan-elastic jan-elastic Awaiting requested review from jan-elastic

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChrisHegarty @elasticsearchmachine @drewdaemon @idegtiarenko @bpintea