Expose model registry to SemanticTextFieldMapper#126635
Merged
jimczi merged 8 commits intoelastic:mainfrom Apr 15, 2025
Merged
Conversation
This change integrates the new model registry with the `SemanticTextFieldMapper`, allowing inference IDs to be eagerly resolved at parse time. It also preserves the existing lenient behavior: no error is thrown if the specified inference id does not exist, only a warning is logged.
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
kderusso
reviewed
Apr 10, 2025
Member
kderusso
left a comment
There was a problem hiding this comment.
Nice change and glad it was easier to achieve than we previously thought! One question on synchronization and waiting on green CI.
...plugin/inference/src/main/java/org/elasticsearch/xpack/inference/registry/ModelRegistry.java
Outdated
Show resolved
Hide resolved
...plugin/inference/src/main/java/org/elasticsearch/xpack/inference/registry/ModelRegistry.java
Outdated
Show resolved
Hide resolved
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Apr 15, 2025
This change integrates the new model registry with the `SemanticTextFieldMapper`, allowing inference IDs to be eagerly resolved at parse time. It also preserves the existing lenient behavior: no error is thrown if the specified inference id does not exist, only a warning is logged.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 15, 2025
This change integrates the new model registry with the `SemanticTextFieldMapper`, allowing inference IDs to be eagerly resolved at parse time. It also preserves the existing lenient behavior: no error is thrown if the specified inference id does not exist, only a warning is logged.
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Apr 16, 2025
This change integrates the new model registry with the `SemanticTextFieldMapper`, allowing inference IDs to be eagerly resolved at parse time. It also preserves the existing lenient behavior: no error is thrown if the specified inference id does not exist, only a warning is logged.
kderusso
added a commit
to kderusso/elasticsearch
that referenced
this pull request
Apr 18, 2025
)" This reverts commit c906cc0.
1 task
viduni94
added a commit
to elastic/kibana
that referenced
this pull request
Apr 21, 2025
Closes #218497 ## Summary The summarize tests were skipped last week because they were failing and blocking pipelines. These tests have started to fail after the merge of elastic/elasticsearch#126635 These changes were reverted last week in elastic/elasticsearch#127075 Therefore, this PR unskips the tests. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 21, 2025
Closes elastic#218497 ## Summary The summarize tests were skipped last week because they were failing and blocking pipelines. These tests have started to fail after the merge of elastic/elasticsearch#126635 These changes were reverted last week in elastic/elasticsearch#127075 Therefore, this PR unskips the tests. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 766cd47)
kibanamachine
added a commit
to elastic/kibana
that referenced
this pull request
Apr 21, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Obs AI Assistant] Unskip summarize tests (#218728)](#218728) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"viduni.wickramarachchi@elastic.co"},"sourceCommit":{"committedDate":"2025-04-21T16:07:54Z","message":"[Obs AI Assistant] Unskip summarize tests (#218728)\n\nCloses https://github.com/elastic/kibana/issues/218497\n\n## Summary\n\nThe summarize tests were skipped last week because they were failing and\nblocking pipelines.\n\nThese tests have started to fail after the merge of\nhttps://github.com/elastic/elasticsearch/pull/126635\nThese changes were reverted last week in\nhttps://github.com/elastic/elasticsearch/pull/127075\n\nTherefore, this PR unskips the tests.\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"766cd471765c1466c4b12005e04ef39e5f5ed04b","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0"],"title":"[Obs AI Assistant] Unskip summarize tests","number":218728,"url":"https://github.com/elastic/kibana/pull/218728","mergeCommit":{"message":"[Obs AI Assistant] Unskip summarize tests (#218728)\n\nCloses https://github.com/elastic/kibana/issues/218497\n\n## Summary\n\nThe summarize tests were skipped last week because they were failing and\nblocking pipelines.\n\nThese tests have started to fail after the merge of\nhttps://github.com/elastic/elasticsearch/pull/126635\nThese changes were reverted last week in\nhttps://github.com/elastic/elasticsearch/pull/127075\n\nTherefore, this PR unskips the tests.\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"766cd471765c1466c4b12005e04ef39e5f5ed04b"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218728","number":218728,"mergeCommit":{"message":"[Obs AI Assistant] Unskip summarize tests (#218728)\n\nCloses https://github.com/elastic/kibana/issues/218497\n\n## Summary\n\nThe summarize tests were skipped last week because they were failing and\nblocking pipelines.\n\nThese tests have started to fail after the merge of\nhttps://github.com/elastic/elasticsearch/pull/126635\nThese changes were reverted last week in\nhttps://github.com/elastic/elasticsearch/pull/127075\n\nTherefore, this PR unskips the tests.\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"766cd471765c1466c4b12005e04ef39e5f5ed04b"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
pgayvallet
pushed a commit
to pgayvallet/kibana
that referenced
this pull request
Apr 22, 2025
Closes elastic#218497 ## Summary The summarize tests were skipped last week because they were failing and blocking pipelines. These tests have started to fail after the merge of elastic/elasticsearch#126635 These changes were reverted last week in elastic/elasticsearch#127075 Therefore, this PR unskips the tests. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
Closes elastic#218497 ## Summary The summarize tests were skipped last week because they were failing and blocking pipelines. These tests have started to fail after the merge of elastic/elasticsearch#126635 These changes were reverted last week in elastic/elasticsearch#127075 Therefore, this PR unskips the tests. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change integrates the new model registry with the
SemanticTextFieldMapper, allowing inference IDs to be eagerly resolved at parse time. It also preserves the existing lenient behavior: no error is thrown if the specified inference id does not exist, only a warning is logged.