Remove unnecessary generic params from action classes#126364
Merged
rjernst merged 4 commits intoelastic:mainfrom Apr 7, 2025
Merged
Remove unnecessary generic params from action classes#126364rjernst merged 4 commits intoelastic:mainfrom
rjernst merged 4 commits intoelastic:mainfrom
Conversation
Transport actions have associated request and response classes. However, the base type restrictions are not necessary to duplicate when creating a map of transport actions. Relatedly, the ActionHandler class doesn't actually need strongly typed action type and classes since they are lost when shoved into the node client map. This commit removes these type restrictions and generic parameters.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 11, 2026
* Remove unnecessary generic params from action classes Serverless side of elastic#126364 * update submodule * update submodule * Merge upstream and update elasticsearch submodule to 991e80d --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Feb 11, 2026
* Remove unnecessary generic params from action classes Serverless side of elastic#126364 * update submodule * update submodule * Merge upstream and update elasticsearch submodule to 991e80d --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transport actions have associated request and response classes. However, the base type restrictions are not necessary to duplicate when creating a map of transport actions. Relatedly, the ActionHandler class doesn't actually need strongly typed action type and classes since they are lost when shoved into the node client map. This commit removes these type restrictions and generic parameters.