Fix data stream retrieval in TimeSeriesDataStreamsIT#125621
Merged
nielsbauman merged 1 commit intoelastic:mainfrom Mar 26, 2025
Merged
Fix data stream retrieval in TimeSeriesDataStreamsIT#125621nielsbauman merged 1 commit intoelastic:mainfrom
TimeSeriesDataStreamsIT#125621nielsbauman merged 1 commit intoelastic:mainfrom
Conversation
This test had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by elastic#122852 Fixes elastic#124987
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
commented
Mar 25, 2025
| }); | ||
| assertBusy(() -> { | ||
| final var backingIndices = getDataStreamBackingIndexNames(dataStream); | ||
| assertEquals(PhaseCompleteStep.finalStep("hot").getKey(), getStepKeyForIndex(client(), backingIndices.getFirst())); |
Contributor
Author
There was a problem hiding this comment.
I originally added two assertBusys because I thought we needed the 20 second timeout. In hindsight, I don't think we actually do. This also avoids the issue with the two back-to-back GET data stream API calls.
nielsbauman
added a commit
to nielsbauman/elasticsearch
that referenced
this pull request
Mar 27, 2025
This test could still fail by consecutive API calls hitting different nodes with different versions of the cluster state. Follow-up of elastic#125621 Relates elastic#125752 (but doesn't close it, as that issue includes two different failures)
This was referenced Mar 27, 2025
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
This test had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet. Caused by elastic#122852 Fixes elastic#124987
nielsbauman
added a commit
that referenced
this pull request
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test had the potential to fail when two consecutive GET data streams requests would hit two different nodes, where one node already had the cluster state that contained the new backing index and the other node didn't yet.
Caused by #122852
Fixes #124987